Sunnyside landing page fully responsive across all screen sizes

Community feedback

• 

  Shashree Samuel•9,260

  @shashreesamuelPosted over 2 years ago

  Good job with this challenge Sammy. keep it up.

  In terms of your accessibility issues

  • <ul> and <ol> must only directly contain <li>, or <template> elements. This means that you can only have ```<li>```, ```script``` and ```template``` elements within a ```ul``` or ```ol``` tag.

  • Your IDs used in aria and your labels must be unique therefore it should only be mentioned once in your document.

  In terms of your html validation errors

  • you have a duplicate id called gallery__item--cone

  • Your url for GitHub is missing a slash in your anchor tag

  • Your aria-labelled by must point to an element within the same document so recheck your code and ensure that you are referring to an image that is present in the same folder

  I hope this helps

  Cheers, Happy coding 👍

  Marked as helpful

  0

  ---

  

  Sammy•280

  @soyedPosted over 2 years ago

  @TheCoderGuru Hi Thanks for the feedback I am going to make the changes you suggested 😊

  Cheers!

  0
• 

  Ozan Zorlu•280

  @zorluozanPosted over 2 years ago

  Hi Sammy,

  Nice work. Here are some suggestions if you want to improve your project;

  1- You shouldn't use div element inside ul element. Instead, you can just give li element and to reach that element, you can use last-child selector. If you want to read about last-child check this out: https://developer.mozilla.org/en-US/docs/Web/CSS/:last-child?retiredLocale=en

  2- ID's in CSS are unique and you should be careful about naming them. I don't prefer to use IDs unless I write any js code.

  3- You missed some hover effects such as icons in footer. Also, if you check the design, you'll see that learn more has underlining effect in it. You should check active states :)

  That's all I wanted to say about. Keep coding :)

  Marked as helpful

  0

  ---

  

  Sammy•280

  @soyedPosted over 2 years ago

  @zorluozan Hi Thanks for the feedback I am going to make the changes you suggested 😊

  Cheers!

  0