FAQ Accordion Card Menu

Community feedback

• 

  Naveen Gumaste•10,480

  @NaveenGumastePosted over 2 years ago

  Hello Hasan Çontuk ! Congo 👏 on completing this challenge

  Let's look at some of your issues, shall we:

  • check my solution you get where you went wrong

  • Add Main tag after body <main class="container"></main>

  happy Coding😀

  Marked as helpful

  0
• 

  Ozan Zorlu•280

  @zorluozanPosted over 2 years ago

  Hi Hasan, Nice work. Here are some suggestions if you want to improve your project;

  1- I think you should check dl element usage. Instead of using dl element, you can use div element for each item. Check this link for dl https://html.spec.whatwg.org/multipage/grouping-content.html#the-dl-element

  2- I think you have some problem about responsiveness. You should fix responsibility because when I shrink the screen, most of the things are overflowing.

  3- Your cube in desktop version is not fixed onto the image. If you check the design, you should fix that and whenever you shrink or grow the page, it shouldn't be go away. You can use absolute positioning for this.

  4- It is good to use jquery but when you use them, you should create a js file and write the code inside that. With this way, your code will be reusable. But if you want to do inside html file, then do this before the closing of the body. And you don't have to use type attribute when defining script tag.

  That's all I wanted to say. Keep coding :)

  Marked as helpful

  0

  ---

  

  Hasan Çontuk•40

  @HasanHiramPosted over 2 years ago

  @zorluozan Thanks a lot for your constructive comment Ozan.

  1- Yeah, I realized it after I submitted the solution but it was late

  2- For this one I was thinking that we just need to design for exact mobile screen as image in design folder. Okay, I will do it as you said from now on.

  3- Same reason with 2.

  4- Got it

  Thank you so much again.

  0

  

  Ozan Zorlu•280

  @zorluozanPosted over 2 years ago

  @HasanHiram You can update your solution. You just change whatever you want to change and push github and also deploy your preview website.

  0
• 

  Hasan Çontuk•40

  @HasanHiramPosted over 2 years ago

  Thanks a million Naveen!

  0