This was a fairly simple challenge I felt. It was nice getting to make an accordion using native html components with no javascript though.
What challenges did you encounter, and how did you overcome them?None.
What specific areas of your project would you like help with?No specific areas.
Wooooow, so nice and clean! What an amazing job🤩👍💕
Looking at github, there are many tools that I've never seen before. I'm curious about your work process!
How did you write this code without JavaScript? I'd really appreciate it if you could let me know! Thanks :D
Beautifully done!🎉
Here's a little suggestion for a nicer code.
Simplify show/hide logic
classList.add and classList.remove are repeated. How about using classList.toggle? I think the code will be much simpler!I'm looking forward to your next challenge. Happy coding :D
I'm proud of the approach i've this time, i have to understand better JS.
Beautifully done!🎉 What a neat file organization! It's amazing that you're organizing SASS folders with global/components. I'll try it next time :D
Here's a little suggestion for a nicer code.
Handling negative number case
Code refactoring
I'm looking forward to your next challenge! Happy coding💪
Well, there’s nothing to be proud of. I am as happy as ever to have finished another challenge.
What challenges did you encounter, and how did you overcome them?Despite facing many challenges along the way, I initially had no idea how I would make everything work out. Thankfully, in the end, it all came together! I've shared a detailed account of my experiences in my README file, as it would take quite a bit of space to cover everything here.
What specific areas of your project would you like help with?My desktop design is nearly identical. However, I did have trouble making the name "Jeremy Robson" appear in two lines instead of one. What would be the simplest way to do this? Also, please let me know if there are any areas of improvement in my SASS and Javascript.
Beautifully done!🎉
Handling codes a lot with JS while keeping your HTML & CSS simple is really cool! I never thought about adding svg icons case by case by JS, I think that's a good idea👍
Here's a little suggestion for a nicer code.
Code refactoring
.toLowerCase() would be good for refactoring your code, since there's a bit of duplication. Check the code below!const handleView = (e) => {
handleButtonStyle(e);
const timeframe = e.target.textContent.toLowerCase();
populateDOM(data, timeframe);
};
Beautifully done!🎉
I think the quality will be much better with a little touch.
On the responsive screen of the desktop version, the image becomes smaller than the container. Try this!
@media (min-width: 50rem) {
.signUpForm__picture {
width: auto; /*Changing to 100% will solve the problem*/
}
}
I'm looking forward to your next challenge. Happy coding :D
Beautifully done! 🤩
Like the smooth transition of the responsive layouts. I'm looking forward to your next challenge:D
