
Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
I'm proud of the approach i've this time, i have to understand better JS.
Community feedback
- @zeeguPosted about 1 month ago
Beautifully done!🎉 What a neat file organization! It's amazing that you're organizing SASS folders with global/components. I'll try it next time :D
Here's a little suggestion for a nicer code.
Handling negative number case
- Even if there are negative numbers in the Bill, Select Tip, and Number of People input field, the result comes out. Check out screenshot!
- When a negative number is entered, it would be much better if there was validation to show the error status.
Code refactoring
- There seems to be a lot of logic in one function. How about dividing it by function for convenient maintenance? It would be good for code refactoring :)
I'm looking forward to your next challenge! Happy coding💪
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord