Skip to content
OverviewSolutions
3
Comments
2
Will Cook
@willcook4

All comments

  • Will Cook•150
    @willcook4Posted about 5 years ago

    A really good first try.

    • Consider fixing the issues raised in your report above. Things like aria labels are important but easy to forget.

    • Clean up your stylesheet. A standard format of

    selector {
    property1: arg;
    property2: arg;
}

    this will make it easier to read/work with. Keep consistent.

    • Clean up your html file. You have things commented out. If it isn't a comment then consider cleaning it away.

    • Your JS file has a surplus console.log in it. Decide if you need this in production. Also consider removing the extra lines in the js file. One between your event listener and your function will do.

    • Update your readme. You will forget what this challenge is about later. Make it easy for you and for others to see what you were doing and why.

    1
  • Brian Patterson•130
    @amidabrian51Submitted about 5 years ago

    Any suggestions on it good be improved greatly appreciated. Will not start on another project.

    html, css and flex.

    2
    Will Cook•150
    @willcook4Posted about 5 years ago

    Great first crack... I think your 'per month' text and your 'why us' list is the wrong color. Check the design again, I don't have the .sketch file though.

    Consider cleaning up the index.html to make it flow. The indentation is a bit wonky making it harder to read.

    'Why us' should probably be an unordered list. It reads like a list.

    Consider cleaning up the spacing in the stylesheet. Your line breaks are inconsistent making it harder to read. Your indentation is inconsistent for .right-box on mobile.

    Give it a tidy up, in general it's looking the part

    3