Deepaknar• 20
@Deepaknar
Submitted
Tim Avidon
@timavidon
All comments
- Tim Avidon• 300
@timavidon
Posted
The image is not displayed, because in the code you wrote:
<img src="assets/images/image-omelette.jpeg" alt="">but you haven't uploaded the assests folder, where your image file is located, to github.
Overall you did a good job 👍
Marked as helpful
0 - mircodev• 60
@mircodg
Submitted
What are you most proud of, and what would you do differently next time?
Getting faster and more confident as I keep building
What challenges did you encounter, and how did you overcome them?
None.
What specific areas of your project would you like help with?
Any feedback is appreciated.
Tim Avidon• 300@timavidon
Posted
Good job 👍
0 - Amin Xatiashvili• 40
@AminXatia
Submitted
What are you most proud of, and what would you do differently next time?
I'm so happy that I could finish this mini-project with patience because there were some minor issues when I wanted to change the styles in active status and I manage to take care of them by searching and asking questions without getting angry and finished it with such a pleasure and I try to do this for my future projects too.
What challenges did you encounter, and how did you overcome them?
I had some problems when I wanted to design the template in active status. (hover & box-shadow) and to overcome them, I looked them up via internet and got help from other developers and the helped me.
What specific areas of your project would you like help with?
I guess the project is complete but if there is any problem, I would be glad to know.
Tim Avidon• 300@timavidon
Posted
You did a great job 👍 Looks like the example.
0 - Jarmo• 80
@Jarmovd
Submitted
What are you most proud of, and what would you do differently next time?
Next time I would like to try to use scss instead of normal css but had trouble installing it with this project
What challenges did you encounter, and how did you overcome them?
No trouble with HTML or CSS
What specific areas of your project would you like help with?
Installing Sass and using scss
Tim Avidon• 300@timavidon
Posted
Good job 👍 You can also add a color like in the example to the h1 heading to make it look similar.
0 - Che Fernandez• 190
@CheFernandez99
Submitted
i found it quite difficult to properly round off the borders of each component in results. the media query was a pain. also could not overlap the right box onto the left i tried using the shadowing to create that illusion. lastley idk if its cause this is a newb project but the media query only works on mobile its not optimised to tablets and ipads...which i intend to run into in future.
Tim Avidon• 300@timavidon
Posted
I recommend putting the left-card and right-card divs inside a div (or something semantic like section or article). In my opinion, this will help you layout more easily with flex or gird.
For the button, I recommend doing
border-radius: 100vw; so you don’t have to guess the right number to make it round.For the summary items, I recommend using rems instead of % in the border-radius. something like
border-radius: 0.5rem;. in general its better to use rems for margins, padding, font-size. It's okay to use 50% for the border-radius like you did for the cirlce 👍For the circle, I recommend doing a width of 12.5rem and height 12.5rem, instead of height (you can also do
aspect-ratio: 1 / 1;, it will set the height like the width that you set). To center the circle I recommend doing margin-inline: auto (it will set the margins on the sides to auto).Overall, you still did a good job. I am sure that in the future you will be able to do it more professionally as you want.
Marked as helpful
1 - elci-coder• 40
@Nelson-elci
Submitted
I couldn't add border-radius to the Scan QR image. I tried with border-radius: 30px; but no effect. How do I achieve that?
Tim Avidon• 300@timavidon
Posted
To achieve this you need to do it on the img itself.
try to do,
#scanqr img { border-radius: 30px }you can also do,
img { border-radius: 30px }Marked as helpful
0
