Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Social-links-profile using html and css

mircodev 60

@mircodg

Desktop design screenshot for the Social links profile coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

Getting faster and more confident as I keep building

What challenges did you encounter, and how did you overcome them?

None.

What specific areas of your project would you like help with?

Any feedback is appreciated.

Community feedback

@0xabdulkhaliq

Posted

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have a suggestion regarding your code that I believe will be of great interest to you.

MAKING ACCESSIBLE LINKS:

  • The links like Github, Frontend Mentor are needed to be actual <a> elements which are wrapped up using li and ul elements. Because we need to use semantic elements to improve accessibility of our solution.
  • This is the current markup,
 <div>GitHub</div>
 <div>Frontend Mentor</div>
  ....
  • In order to make this solution accessible, we need to use <a> elements with href attribute. Here's the example
<ul>
    <li>
       <a href="#">Github</a>
    </li>
    <li>
       <a href="#">Frontend Mentor</a>
     </li>
    ...
</ul>
....
  • Additionally you need to add display: block for a elements in order to style them, because by default they inline elements.
  • If you have any questions or need further clarification feel free to reach out to me.

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

0

mircodev 60

@mircodg

Posted

Thank you for the feedback! @0xabdulkhalid . I get what you mean and I agree. I didn't put the <a> tag just because it was a demo and I didn't mean to put any of my links so I used multiple divs with the same class in order to style them faster and easily.

0
Tim Avidon 300

@timavidon

Posted

Good job 👍

0

mircodev 60

@mircodg

Posted

Thank you so much! @timavidon

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord