@0xabdulkhaliq
Posted
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have a suggestion regarding your code that I believe will be of great interest to you.
MAKING ACCESSIBLE LINKS:
- The links like
Github
,Frontend Mentor
are needed to be actual<a>
elements which are wrapped up usingli
andul
elements. Because we need to use semantic elements to improve accessibility of our solution.
- This is the current markup,
<div>GitHub</div>
<div>Frontend Mentor</div>
....
- In order to make this solution accessible, we need to use
<a>
elements withhref
attribute. Here's the example
<ul>
<li>
<a href="#">Github</a>
</li>
<li>
<a href="#">Frontend Mentor</a>
</li>
...
</ul>
....
- Additionally you need to add
display: block
fora
elements in order to style them, because by default theyinline
elements.
- If you have any questions or need further clarification feel free to reach out to me.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful
@mircodg
Posted
Thank you for the feedback! @0xabdulkhalid . I get what you mean and I agree. I didn't put the <a> tag just because it was a demo and I didn't mean to put any of my links so I used multiple divs with the same class in order to style them faster and easily.