Skip to content
OverviewSolutions
10
Comments
10
suhaib52
@suhaib52

All comments

  • suhaib52•280
    @suhaib52Posted almost 2 years ago

    You did it in a very good manner. Your code is well structured and readable.

    It would be nice if you start using semantic html tags, these tags would reduce the accessibility issues.

    You can also use :root to define the colors and then call them by using var() in your stylesheet. When you use the colors as a variable than your css code will look more precise.

    Marked as helpful
    1
  • suhaib52•280
    @suhaib52Posted almost 2 years ago

    You did it in a very good manner. Your code is well structured and readable.

    It would be nice if you start using semantic html tags, these tags would reduce the accessibility issues.

    You can also use :root to define the colors and then call them by using var() in your stylesheet.

    I do not understand why you create separate style sheet for mobile and desktop.

    Marked as helpful
    1
  • suhaib52•280
    @suhaib52Posted almost 2 years ago

    Good job! Your code is well structured and readable. For html, try to use semantic html tags. Semantic html tag would help to improve the accessiblity.

    Marked as helpful
    0
  • suhaib52•280
    @suhaib52Posted almost 2 years ago

    It would be better if you use the semantic html tags because these tags would reduce the accessibility issues.

    You can also define the body in more details to make it more better such as; body { width: 100%; height: 100vh; display: flex; align-items: center; justify-content: center; font-family: 'Karla', sans-serif; background-color: var(--grayishBlue); font-size: 16px; }

    Also use the margin 0 auto on the card id so it should be in the center of the page.

    It would be nice if you use classes more as compared to the ids.

    Marked as helpful
    0
  • suhaib52•280
    @suhaib52Posted almost 2 years ago

    Your code is well structured and easily readable. Good job! You can define the colors by using :root at the start of the style sheet and then call them by using var().

    Marked as helpful
    0
  • Myro Joy Lee•120
    @myrojoyleeSubmitted almost 2 years ago

    Done a week of coding!

    I had the hardest time with lining up the background images. I ended up just doing what Mr. Coder on YT (https://www.youtube.com/watch?v=NZpG9EBKYWc) did after trying for hours and not fully understanding how to get it to where I needed it to be...

    I also do not understand how the profile picture got to be on top of the header background, because I tried all sorts of z-index lines getting nowhere, and then it magically happened in the midst of deleting unnecessary lines, so I'm not even sure what I did.

    Thanks so much for all the comments so far in the other challenges I've done...I'm still trying to get better at not ending up with a million lines of code, so if you see me repeat myself excessively, please let me know!

    Profile card using HTML and CSS

    1
    suhaib52•280
    @suhaib52Posted almost 2 years ago

    I think you need to use the position relative and then use bottom property to move the profile picture.

    2
  • Shraddha Vkarma•40
    @Shraddha-V22Submitted almost 2 years ago

    1- Assuming the actual width and properties of elements was a bit challenging. 2- I am unsure whether I have written an efficient code or not. 3- There are couple of doubts about best practices and whether I am practicing them or not.

    Product preview card component using CSS flexbox

    2
    suhaib52•280
    @suhaib52Posted almost 2 years ago

    Your code is looking clean. It would be great if you use classes as compared to the ids in the html, because use of classes considered best practice as compared to the ids.

    Marked as helpful
    0
  • suhaib52•280
    @suhaib52Posted almost 2 years ago

    It would be great to use semantic tags than the div, because semantic tags improve the accessiblity.

    You can also try :root in the css to define the colors at the start of the file then you can use var() to call the color.

    Marked as helpful
    0
  • suhaib52•280
    @suhaib52Posted almost 2 years ago

    Your code is looking clean and easy to read. Try to use :root to define the colors once at the start of the css sheet and then just call them by using color: var(). It is also nice if you define the font in the style sheet rather than in the html file. For image it is also good practice to add the width and height attribute in the image tag.

    Marked as helpful
    1
  • suhaib52•280
    @suhaib52Posted over 2 years ago

    Hello Lovish,

    Your solution is very clean. I like your approach. It would be better if you add external style sheet. That would make your code more readable. Best of luck for next time!

    Marked as helpful
    0