Order-Summary-Component-main Build With : HTML5 & CSS

Community feedback

• 

  Abdul•8,540

  @SamadeenPosted over 2 years ago

  Hey Lovish!! Cheers 🥂 on completing this challenge.. .

  Here are my suggestions..

  • Go down orderly when you are using the headings h1 down to h2 down to h3 and so on.
  • You can wrap your attribution section in a footer tag to avoid accessibility issues.
  • You should not nest your headings in a span

  This should fix most of your accessibility issues

  . Regardless you did amazing... hope you find this useful... Happy coding!!!

  Marked as helpful

  2
• 

  suhaib52•280

  @suhaib52Posted over 2 years ago

  Hello Lovish,

  Your solution is very clean. I like your approach. It would be better if you add external style sheet. That would make your code more readable. Best of luck for next time!

  Marked as helpful

  0

  ---

  

  Lovish Duggal•180

  @lovishduggalPosted over 2 years ago

  @suhaib52 Thank you Sir

  0
• 

  Lucas 👾•104,340

  @correlucasPosted over 2 years ago

  Hello Lovish, nice solution you've.

  I saw some things that differs from the Frontend Mentor design:

  • You should follow an order between your solutions headings, it seems that you jumped from h1 to h5, take a look.
  • The h5 inside annual-plan-box isn't bold, it should be "font-weight: 500"
  • The plan div should aligned left with "text-align: left".

  Overall I think you've done it very well.

  Marked as helpful

  0