Resposive with Flexbox

Community feedback

• 

  suhaib52•280

  @suhaib52Posted almost 2 years ago

  You did it in a very good manner. Your code is well structured and readable.

  It would be nice if you start using semantic html tags, these tags would reduce the accessibility issues.

  You can also use :root to define the colors and then call them by using var() in your stylesheet.

  I do not understand why you create separate style sheet for mobile and desktop.

  Marked as helpful

  1

  ---

  

  Hugo Almeida•730

  @almeida883Posted almost 2 years ago

  @suhaib52 Very grateful for your suggestion, I will improve these points, thank you.

  0
• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hi there 👋. Good job on completing the challenge ! I have some feedback for you if you want to improve your code.

  HTML:

  • Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.

  • You should use only one <h1> tag per page. The <h1> tag is the most important heading tag, This can confuse screen reader users and search engines. This challenge requires that Sedans, SUVs and Luxury are headings, but you can use the <h2> tag instead of the <h1> tag. You can read more about this here.

  • You should use the <a> tag instead of the <button> tag because the Learn More button is a link to another page. Use buttons to perform actions like submitting a form or closing a modal and use links to navigate to another page. You can read more about this here.

  • Not all images should have alt text. Car icons are for decoration purposes only, so they can be hidden from screen-readers by adding aria-hidden="true" and leaving its alt attribute empty:

  <img src="./images/icon-sedans.svg" alt aria-hidden="true">
  <img src="./images/icon-suvs.svg" alt aria-hidden="true" >
  <img src="./images/icon-luxury.svg" alt aria-hidden="true" >
  

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  0