Leonardo Campos• 10
@leonardocampos19
Submitted
steevencode
@steeven509
All comments
- steevencode• 120
@steeven509
Posted
Hello @Leonardo Campos , I hope everything is okay for you ?
I'm really impressed with the design it's so close to the original However i have small notes for you: *Your accessibility has a lot of warnings you need to fix them *You must use semantic tags *Improve the alternative text of the QR code by describing the purpose of the QR code. "QR code to frontendmentor.io" can be a good alternative text for it. *Use a CSS reset whenever you start a new project. This can help you set the styling foundation easily. My recommendation — A Modern CSS Reset *Never limit the height of the <body>. It will not allow the users to scroll the page when the page content needs more height. Try to look at the site on a mobile landscape view to see the issue. So, use min-height: 100% instead. *Never use px unit for font sizes. Use rem or em instead. Relative units such as rem and em can adapt when the users change the browser's font size setting.
I hope you find this useful. 🙂
Marked as helpful
1 - Alan Souza• 100
@alansouza7
Submitted
steevencode• 120@steeven509
Posted
Hi, I have not checked your source code yet but the report indicates that you have a accessibility problem, if this feedback has helped you mark it as util thanks you
0 - hafsa• 10
@hafsabn
Submitted
I really have a big problem in position the text in the same line with images that's why i am not sure in my code especially in the areas where there are a text and a picture in front of it . So if there are some resources or practices to learn more in this subject please let me know and thanks.
steevencode• 120@steeven509
Posted
Hi, I have not checked your source code yet but the report indicates that you have a lot of accessibility problem, if this feedback has helped you mark it as util thanks you
0 - Elif Seyhan• 180
@elifseyhan
Submitted
steevencode• 120@steeven509
Posted
Hi, I have not checked your source code yet but the report indicates that you have a lot of accessibility problem, if this feedback has helped you mark it as util thanks you
0 - José Luna• 200
@phoenixrx
Submitted
L COULDN'T MAKE THE BACKGROUNG LOOKS LIKE THE ORIGINAL :(
steevencode• 120@steeven509
Posted
Hi, I have not checked your source code yet but the report indicates that you have a lot of accessibility problem, if this feedback has helped you mark it as util thanks you
0 - Ditya Athallah• 160
@Dityath
Submitted
Hi, this is my Advice Generator App, created with Vite and React.js. With Axios and Framer-Motion.
Any feedbacks are welcome!
steevencode• 120@steeven509
Posted
This comment was deleted
0 @ralvarezrenzo
Submitted
Any comments to improve are welcome, greetings good code.
steevencode• 120@steeven509
Posted
Hi, I have not checked your source code yet but the report indicates that you have a accessibility problem, if this feedback has helped you mark it as util thanks you
0@preciousyaks17
Submitted
I would appreciate any form of feedback, in order to do better and improve my skills.
steevencode• 120@steeven509
Posted
Hi, I have not checked your source code yet but the report indicates that you have a lot of accessibility problem, if this feedback has helped you mark it as util thanks you
0- Sonu Swapan Dutta• 530
@Sonu-Dutta
Submitted
steevencode• 120@steeven509
Posted
Very Gooooooood
1 - Sonu Swapan Dutta• 530
@Sonu-Dutta
Submitted
steevencode• 120@steeven509
Posted
Hello Sonu check the report there really is a lot to learn and design on mobile is unresponsive
I did not check your source code
0 - Carolina Gullón• 10
@carogullon
Submitted
steevencode• 120@steeven509
Posted
Hola, esto es muy bueno, pero mira los problemas de accesibilidad que veo que tienes. Para solucionar este problema aquí hay un enlace que explica todo.
https://dequeuniversity.com/rules/axe/4.3/landmark-one-main?application=axeAPI
Para tu información, olvidaste los pesos de las fuentes
0 - Alana Nanz• 40
@alana-nanz
Submitted
steevencode• 120@steeven509
Posted
Amazing
0
