Hi everyone! This is my first react typescript projects. Any suggestions are highly appreciated. Thanks.
Sophie Bushchak
@sophiebushchakAll comments
- @jhunxeinSubmitted over 3 years ago@sophiebushchakPosted over 3 years ago
Hello, I think somehow you have placed the incorrect link on your submission, because in the preview it shows the login to Vercel.
I have looked at the solution though and it looks very nice. But I am wondering, why would you build this in React? There is nothing dynamic in the page. Were you practicing creating components and the React application structure?
0 - @anaharriSubmitted over 3 years ago
I applied the changes that frontendmentor and my peers suggested
@sophiebushchakPosted over 3 years agoThis is a minor detail but I think this would improve your design a little. Right now your smaller font sizes (the ones on the text "Try it free 7 days then $20/mo. thereafter" and "Claim your free trial" ) are the same no matter if you are viewing it on a large screen or a mobile screen. On the mobile screen it makes sense that the text is small like this. But on a bigger screen it would be nicer if the text was a bit bigger. If you look at the design vs your solution too you will see that your fonts are a tiny bit undersized.
Otherwise it is a very nice solution and looks perfect!
0 - @DrKlonkSubmitted over 3 years ago
-
I had trouble getting the SVGs in an external file and then apply the filters in CSS. Couldn't make it work. Fixed it down and dirty now. Is there a way to properly do this?
-
Is there a good way to add styling to the autocompletion of an email input field?
@sophiebushchakPosted over 3 years agoSome feedback:
On a very small screen size, the platform SVG's shrink to be almost unreadable, you could probably let them stay a tiny bit larger until there's really no space for it: https://puu.sh/HtnSN/1ba6aed03a.png
Maybe put a max width on the content or find some way to scale the image and text block to be bigger, because on a 1440p screen it stops looking like the design at all and the image and text are completely separated: https://puu.sh/HtnT4/d6dd89649c.png
1 -