faizan• 2,420
@afaiz-space
Submitted
lot fun with this work.
scarydeveloper
@snake321
All comments
- scarydeveloper• 130
@snake321
Posted
You have done good job but there is a lot of mistakes which you should correct
/* IN body you should keep
<main> and container different and then apply display flex to keep your conten in center */ /* main{ display: flex; align-items: center; justify-content: center; min-height: 100vh; } */ and then apply grid on container container{ margin: 0 auto; padding: 15px;/* padding should be padding 2rem 3rem */ width: 80rem;/* keep it width 100% to keep it responsive */ display: grid; } Hope this help!... Keep coding👍0 - Prince Kumar• 40
@kprince26
Submitted
scarydeveloper• 130@snake321
Posted
on button you should keep cursor pointer and remove the outline of button when you will click it you will get it otherwise good job Keep coding📌👍
1 - boquelito• 20
@boquelito
Submitted
Finally got the GitHub thing, any advice would be cool !
scarydeveloper• 130@snake321
Posted
HEY BRO I am afraid you have to recode your website and use overflow: hidden ; property to stop overflowing and you should also learn about html accessibilities and also you should see your report which is terrible I hope it will help you keep learning and keep coding
Marked as helpful
0 - Samuel M. Setiawan• 200
@samuelms21
Submitted
It was hard positioning the background images, because you have two seperate design element files in the folder. I got some help from those who have done this challenge beforehand. It helps so much. I've also learned that you can actually have multiple background images at once. This challenge so far has taught me the most about vanilla CSS positioning.
scarydeveloper• 130@snake321
Posted
It is also hard for me to set the background so that's why I took the help from your code I learnt that we apply percentages on background position and veiw_port widht
0 - scarydeveloper• 130
@snake321
Submitted
hi guys finally I have completed social Proof section plz give your feedback on my rating section and my stars images is there any better way to specify them? and how to give the margin on background image
scarydeveloper• 130@snake321
Posted
Thank you so much for your valuable feedback
0 - Mohammad Ebrahimi• 250
@moheb2000
Submitted
This challenge wasn't really hard but I don't know if I did box shadow right in my code.
scarydeveloper• 130@snake321
Posted
you have done very good job but when I hover on button it changes the color very fast so to do it slow I think you should use transition on button
1 - scarydeveloper• 130
@snake321
Submitted
hi guys it is my first project so plz visit my solution and share your feedback that how can I grow more and tell me my mistakes plz your feedback is most valuable for me
scarydeveloper• 130@snake321
Posted
thanks for your feedback next time I will not do this kind of mistakes.. thank you so much
0 - scarydeveloper• 130
@snake321
Submitted
hi guys it is my first project so plz visit my solution and share your feedback that how can I grow more and tell me my mistakes plz your feedback is most valuable for me
scarydeveloper• 130@snake321
Posted
thanks for your feedback
0
