Skip to content
OverviewSolutions
11
Comments
13

SMHN

@smhnfreelancer200 points

Web Developer

Latest solutions

View more solutions

Latest comments

  • SMHN•200
    @smhnfreelancerPosted 11 months ago

    Congrats! The screenshot shows that there are some minor CSS changes needed. But both the code and the live website links are broken, you can fix it.

    0
  • Jordan Davenport•1,100
    @jjdavenportSubmitted 11 months ago
    What are you most proud of, and what would you do differently next time?

    Discovering object fit to use with the page images.

    What challenges did you encounter, and how did you overcome them?

    When the validation fails and the error state is displayed, my moves up about one pixel and i still have not found how to fix this.

    What specific areas of your project would you like help with?

    Feedback regarding the validation aspect and my JS in general.

    Newsletter sign up with JS and flexbox

    1
    SMHN•200
    @smhnfreelancerPosted 11 months ago

    Nice work!

    1. The JS Working Perfectly.
    2. You can do the mobile view as well.
    3. When the email is invalid the input border also changes to the tomato color.
    4. Also I saw that you assign colors and other values in Javascript, a better approach is to add or remove a specific CSS class. Regards
    Marked as helpful
    1
  • SMHN•200
    @smhnfreelancerPosted 12 months ago

    Hi Congragulations on completing the task. On the mobile screen, you need to apply the gray bluish background color. regards

    1
  • SMHN•200
    @smhnfreelancerPosted 12 months ago

    Congrats! it's amazing, but I want to mention some points:

    1. set the body's background color to background: #FAFAFA;.
    2. "Experience more together" and "Stay connected with..." in desktop mode are left aligned.
    3. "Built for modern use" font-size is 16px and it's all caps.
    4. Hero images need to be slightly about 20px out of the browser's viewport, you can simply use object-position for that matter

    Again, your design is amazing. Regards

    0
  • SMHN•200
    @smhnfreelancerPosted 12 months ago

    Hi, I don't see any results, but a few points for making the project.

    1. take everything easy, there is no need to be pixel-perfect, and the code is more important.
    2. Use online resources like cheatsheets to understand the CSS grid.
    3. Use the style-guide.md file to find the fonts and also colors.
    4. Use KISS principle and make the project as easy as you can.
    0
  • SMHN•200
    @smhnfreelancerPosted 12 months ago

    Congrats! it's amazing, but a few points to mention:

    1. The line-through text font is Montserrat not Fraunces with about 0.8rem as a font-size.
    2. For the main text line-height:23px is more closer to the original design.
    3. The size of the Add to Cart button is not changing on the hover, this is flat, minimalist design.
    4. Also the mobile view design is not applied. Regards
    1
View more comments