Skip to content
Submitted 7 months ago

Newsletter sign up with JS and flexbox

Jordan Davenport•970
@jjdavenport
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Newsletter sign-up form with success message
  • HTML
  • CSS
  • JS
2junior

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

Discovering object fit to use with the page images.

What challenges did you encounter, and how did you overcome them?

When the validation fails and the error state is displayed, my moves up about one pixel and i still have not found how to fix this.

What specific areas of your project would you like help with?

Feedback regarding the validation aspect and my JS in general.

Community feedback

  • SMHN•200
    @smhnfreelancerPosted 7 months ago

    Nice work!

    1. The JS Working Perfectly.
    2. You can do the mobile view as well.
    3. When the email is invalid the input border also changes to the tomato color.
    4. Also I saw that you assign colors and other values in Javascript, a better approach is to add or remove a specific CSS class. Regards
    Marked as helpful
    1
    Jordan Davenport•970
    @jjdavenportPosted 7 months ago

    @smhnfreelancer Thanks for your feedback, I have updated the code now and fixed all the issues if you take a look, the only thing I haven't solved is why the <legend> moves when the invalid state is triggered.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord