Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
I used the mobile-first approach to make this layout.
What challenges did you encounter, and how did you overcome them?I created another div for the desktop Hero section. I wanted to apply the KISS principle, and I tried to avoid complicated CSS, so there are two different hero sections.
What specific areas of your project would you like help with?I Cheated on BEM naming because I didn't want an extra long CSS class name, I welcome any opinion.
Community feedback
- @yoyov51234Posted 6 months ago
HI There,
Greet solution!
- I learned the overflow-x: clip from your code, good choice!
- I'm new to BEM too, do we allow to have two elements defined like .content__buttons__what (Block, element, element) Rfer to this article, seems it's not. https://sparkbox.com/foundry/bem_by_example
- ( I should do this too ), give more comments in the code, so it will be easy to read/ maintain.
All in all , it's a excellent solution! Better than mine, good work~
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord