Skip to content
OverviewSolutions
10
Comments
10
P
Sergiu Grosu
@sergrosu

All comments

  • pablodev•430
    @PabloodevSubmitted 4 months ago
    What are you most proud of, and what would you do differently next time?

    Hello guys

    Another solution that was very difficult, but I realize that little by little I will increase the fluidity with my lines, both in JavaScript and also in HTML and CSS. I believe that this is all a matter of consistency.

    What challenges did you encounter, and how did you overcome them?

    Well, I think most of my problems were with JavaScript as well as CSS since I was using JavaScript to handle styles but I had to research a lot of documentation and I had help from AI but I was always trying to learn

    What specific areas of your project would you like help with?

    Any help on how I can improve the accessibility of my HTML as well as how I handled events in JS

    pablodev | Newsletter Sign-up Form

    1
    Sergiu Grosu•240
    @sergrosuPosted 4 months ago

    You're pretty close. A few things I'd change:

    1. Adjust the font weights to better match the design.
    2. Push the error message all the way to the right to better match the design.
    3. Get rid of the alert appearing when pressing the submit button alert('E-mail válido! Formulário enviado.');
    Marked as helpful
    0
  • Sergiu Grosu•240
    @sergrosuPosted 5 months ago

    Hey, Your images are not working. If hosting on github pages, make sure the link to image is relative, like so: ./assets/image.jpg

    Marked as helpful
    0
  • Sergiu Grosu•240
    @sergrosuPosted 5 months ago

    You're pretty close, I would suggest you fix the following:

    1. Your hero images do not match the design on the sides. The purpose is to make it look like there are more people on the sides, however your implementation cuts the images abruptly.
    2. Fix the font weight on headings.
    Marked as helpful
    0
  • Sergiu Grosu•240
    @sergrosuPosted 5 months ago

    you should probably limit the height of the grid container

    0
  • Sergiu Grosu•240
    @sergrosuPosted 5 months ago

    I would set a max-width to your content, so it doesn't grow infinitely. It looks too big on wide screen.

    0
  • Sergiu Grosu•240
    @sergrosuPosted 5 months ago

    You're pretty close. One thing I would change, is the cart icon: it's a style element and it's probably not a good idea to have it in your html. You can implement it inside your button using the ::before pseudo-element:

    .button-cart::before {
  content: "";
  width: 15px;
  height: 16px;
  background-image: url(../images/icon-cart.svg);
}
    0
  • Tuna Erten•360
    @tunaertenSubmitted 5 months ago
    What are you most proud of, and what would you do differently next time?

    It took longer than I expected. I saw that the project had a lot of details. The Figma file was really helpful. At first, I didn't use flexbox or grid to build the project. After finishing the project and starting to set up media queries, I noticed that when the page began to shrink, it caused many small problems. Therefore, I went back to the beginning and redesigned the page with a grid. This time, I got the result I wanted. In my next project, I will definitely consider this from the start. For the first time in CSS, I used the (:not) operator. I had seen it a few times but had never used it before. Other than that, it was a very enjoyable project. I am eagerly looking forward to the next project.

    What challenges did you encounter, and how did you overcome them?

    I used table for the first time. I frequently referred to MDN pages to recall what I had learned.

    What specific areas of your project would you like help with?

    I definitely need help with landmarks. I read the article, but I keep making mistakes in every project when I try to implement them. I would be very grateful if someone could show me how to use landmarks in my project.

    Recipe page with CSS,Grid,responsive design

    2
    Sergiu Grosu•240
    @sergrosuPosted 5 months ago

    You're very close. I would suggest adjusting the min-height property to 1vh, to get rid of the white space at the bottom of the page:

    body {
min-height: 1vh;
}

    You can also decrease the list markers size with:

    ul::marker {
font-size: 0.75rem;
}
    Marked as helpful
    0
  • Akansha Yadav•50
    @Akansha82Submitted 5 months ago
    What are you most proud of, and what would you do differently next time?

    I'm most proud of successfully completing this Frontend Mentor challenge.

    What challenges did you encounter, and how did you overcome them?

    One of the major challenges I encountered was to properly align the images and text in card.

    What specific areas of your project would you like help with?

    Any guidance on improving responsiveness, optimizing code structure, or enhancing accessibility would be greatly appreciated.

    Responsive Social Links Profile Card

    2
    Sergiu Grosu•240
    @sergrosuPosted 5 months ago

    You're pretty close. Just work a bit more on spacing and sizing.

    Marked as helpful
    0
  • Sergiu Grosu•240
    @sergrosuPosted 5 months ago

    You're pretty close, but I would do the following changes:

    1. Add more padding on the white container
    2. Decrease border radius on the image/ image container
    3. Make the button text bold
    4. Add more margin between image and button
    5. Increase line height on the paragraph to 1.5
    6. Remove the junk at the end.
    Marked as helpful
    0
  • Sergiu Grosu•240
    @sergrosuPosted 5 months ago

    I would suggest the following:

    1. Remove all the extra information from your HTML file
    2. Format the HTML file with Prettier
    3. Insert your component into a <main></main> tag: https://www.w3.org/WAI/ARIA/apg/patterns/landmarks/examples/main.html
    0