Skip to content
OverviewSolutions
13
Comments
5
Sapinder
@sapinder-pal

All comments

  • Vashista Kondeti•40
    @vashista-kondetiSubmitted about 4 years ago

    i tried a lot to position the boxes but nothing happed please help me out

    html css

    1
    Sapinder•565
    @sapinder-palPosted about 4 years ago

    Hi @Vashishta! You can use a grid layout like so-

    .first-box {
  grid-area: first;
}
.second-box {
  grid-area: second;
}
.third-box {
  grid-area: third;
}
.fourth {
  grid-area: fourth;
}
.features {
    display: grid;
    grid-template-columns: repeat(5, 1fr); //repeat 5 columns with equal proportions of width
    justify-content: center;
    grid-template-areas:
        "...       ...             first        ...        ..."
        "...      second    first        third   ..."
        "...      second    ...            third   ..."
        "...      second    fourth    third   ..."
        "...      ...              fourth    ...        ...";
}

    You should read the documentation about grid layout!

    0
  • Diarrah•3,418
    @DiarrahSubmitted about 4 years ago

    Please review my site!

    Anything I can do to make my code cleaner? Also, in your opinion, what could I do to improve your user experience with the project?

    Thank you!

    React with SCSS + Routing

    2
    Sapinder•565
    @sapinder-palPosted about 4 years ago

    Your projects are awesome-ly implemented @Diarrah. It's fabulous!

    0
  • Sapinder•565
    @sapinder-palPosted over 4 years ago

    You did a nice job @sagarkaurav! One thing I would want you to know is that you have to keep in mind the users who set third-party cookies to block, and so do I. This is why my browser prevents frontendmentor from previewing your solution (the original url should work but on this site, it's considered third-party). In my previous challenge, I also encountered the same. So I applied a try and catch block in necessary places. You should also consider this. I had to turn off the third-party cookies to view your page :)

    1
  • Sapinder•565
    @sapinder-palPosted over 4 years ago

    I appreciate your feedback. I'm thinking to improve upon my usage of sass, however, in this project I spent a great amount of my time in implementing a lot of webpack stuff like- mini-css-extract-plugin, postcss-loader, autoprefixer, etc., and understanding how everything works. I'm slowly improving my way of working and forgetting my bad practices. I'll try to improve my sass way of working. Could you please elaborate the 'BEM' and '7:1' you said about?

    0
  • Sapinder•565
    @sapinder-palPosted over 4 years ago
    This comment was deleted over 4 years ago
    0