Samuel
@samuelpklmAll comments
- @RazielTXSubmitted over 2 years ago@samuelpklmPosted over 2 years ago
Your solution is perfect according to the specifications of the exercise. But it looks bad that the height of the card grows a lot when activating all the questions. I suggest you see my solution: (https://www.frontendmentor.io/solutions/faq-accordion-with-htmlcssjs-HkNVRB5Eq) In which I control through events, the activation and hiding of all the cards, to keep the height of my card within a desired margin. This can be done with JQuery's slideDown and slideUp actions.
Marked as helpful0 - @AphatheologySubmitted over 2 years ago@samuelpklmPosted over 2 years ago
your solution is great, the only thing I would suggest is that the option should be permanently marked orange, and not gray, so that the user's option is clearer. but even this suggestion is subjective.
1 - @SangamSmilikaReddySubmitted over 2 years ago@samuelpklmPosted over 2 years ago
The page is not adapted for mobile devices, in addition the icons of social networks do not work as links, they are only background images. You can enhance the mobile layout with the css property: @media screen and (max-width: 375px). there begin to specify the properties of the container for the screen of the width of the mobiles.
Marked as helpful0 - @jesuisbienbienSubmitted over 2 years ago
This was a fun challenge. I found a codepen from SOF, that helps filter the svg color into a desired color. But, what are other (probably) more effective, quicker way to do it?
Any other feedbacks on styles and codes are very much appreciated. I love to learn.
Happy coding, as always.
@samuelpklmPosted over 2 years agoto make the social box disappear you can bind a specific element to a certain event ("click"), to modify the css of the social box so that it is hidden. You could think of the "display" property. You could also hide and show the social media box with the jquery "hiden", "show" functions. accompanied by the animations offered by jquery as well.
Marked as helpful0