@edpauSubmitted about 1 month ago
What specific areas of your project would you like help with?
Please comment on my typescript and code logic.
Ronald Yonggi
@ronaldyonggiAll comments
- @ronaldyonggiPosted 17 days ago
Looks amazing!
In terms of codebase, I'd say it's a good idea to separate your code to components in different files (for example, one component for the profile card, and a reusable component for the activity card). It's also a good idea to keep all your type definition in a separate file instead of altogether in index.ts.
1 - @tatasadiSubmitted 10 months ago
- @chelsea-hereSubmitted 2 months agoWhat are you most proud of, and what would you do differently next time?
I'm proud that I was able to figure out how to set up the pop up so that it had a relative position to the items the styling was based around.
What challenges did you encounter, and how did you overcome them?Getting the styling to be correct was challenging, even after I figured out where to position the pop-up components. I ended up handling the view width aspect with css @ media instead of complicating my react component.
What specific areas of your project would you like help with?I'm always looking for ways to simplify my code. If you have ideas on how to simplify my SharePopUp CSS would love to hear about it!
@ronaldyonggiPosted about 1 month agoLooks good!
I saw a problem when toggling the active-state in mobile view. Seems like the active-state share section in the mobile-view doesn't match the desired mobile design.
Marked as helpful0 - @DmytroGaidukSubmitted 6 months ago
- @Ajaya-RajbhandariSubmitted about 2 months agoWhat are you most proud of, and what would you do differently next time?
-used mobile first approach and added media query for desktop view. -Took a week to finish this project even though i though of quieting.
- Learn some Grid layout and used.
-- Arranging element in grid . -- Got help from freecodecamp about grid layout.
What specific areas of your project would you like help with?** To use grid and flex display layout.
@ronaldyonggiPosted about 2 months agoGood effort!
A few minor details:
- The desired design's background is slight darker
- The desired design card text is not centered
Marked as helpful0 - @kvruntimeSubmitted about 2 months agoWhat challenges did you encounter, and how did you overcome them?
the use of html art directory features.
@ronaldyonggiPosted about 2 months agoLooks good!
Minor details is that in the desktop design, the image's width is slightly smaller than the content section. Compared to the desired design, the image is of equal width with that of the content section.
0 - @hominhk3Submitted 2 months agoWhat are you most proud of, and what would you do differently next time?
ghhhgfj
What challenges did you encounter, and how did you overcome them?kthvnn
What specific areas of your project would you like help with?grdjvb
@ronaldyonggiPosted about 2 months agoYour submission doesn't exactly look like the design.
0 - @scottyrogesSubmitted 9 months ago
First time using CSS modules, took a little bit of time understanding how it works and using PostCSS plugins for things. In terms of implementation the only part that had me stuck was having the width resize responsively between mobile and desktop. I wanted to avoid a media query so that it looked good on all screen sizes, but have it stretch to a point was tricky. Eventually got it using flex-box, max-width and flex
- @hominhk3Submitted 2 months agoWhat are you most proud of, and what would you do differently next time?
fsdf
What challenges did you encounter, and how did you overcome them?sdf
What specific areas of your project would you like help with?fsdf
- @bonssssSubmitted 2 months agoWhat are you most proud of, and what would you do differently next time?
-
What are you most proud of? I’m proud of creating a clean, responsive layout using Flexbox and integrating Google Fonts for a modern look. The project successfully met its goal of improving my front-end skills.
-
What would you do differently next time? Next time, I’d add subtle animations for interactivity, focus more on accessibility, and possibly use CSS Grid for more complex layouts. I’d also consider using SCSS or CSS variables to make styling more efficient.
Responsive design: Ensuring the layout looked good on different screen sizes required some adjustments.
What specific areas of your project would you like help with?Areas for Help Accessibility: Guidance on improving accessibility with ARIA roles and keyboard navigation.
Animations: Tips on implementing subtle hover effects and transitions.
CSS Optimization: Advice on using SCSS or organizing styles for better scalability.
@ronaldyonggiPosted 2 months agoLooks good! I didn't see the part for mobile view in the CSS file, this can be something to be done as for the next steps.
Marked as helpful0 -
