All comments

• 

  P

  Kamran Kiani•1,280

  @kaamiikSubmitted 4 months ago

  What are you most proud of, and what would you do differently next time?

  • Learning how to copy a content with a button. Learning how to generate password and evaluate it.

  • On the css, Learning how to build pure css checkbox and range slider

  What challenges did you encounter, and how did you overcome them?

  • On the css, there was a issue when I wanna build range slider. The background color of the filled value must be different with empty side. I handle this one with JS.

  • On the JS, evaluate strength of the password was challenging. I've used regex to handle this. I'm not sure yet about it and I think I can improve it too.

  What specific areas of your project would you like help with?

  Please take a look at the different parts of my code Specially for Java Script and Accessibility and if you see any issues, give me feedback so I can improve. Thank you.

  

  Password Generator App using Vite, Sass and Vanilla JS

  1

  30
  

  P

  Rohan Tayal•310

  @rohantayalPosted 4 months ago

  Very well-designed Qumran, great job.

  I found a small issue in your project regarding the strength bars. For instance, when I select all charsets and set the password length to 8, it indicates "Strong." However, when I increase the length to 11, even with all the checkboxes checked, it shows "Medium."

  To address this, I suggest removing the condition that deducts a point from the strength value if a character is repeated.

  1
• 

  P

  Ivan Orsolic•240

  @ivanorsolic95Submitted 4 months ago

  

  Responsive component built with CSS Flexbox and CSS Grid

  1

  10
  

  P

  Rohan Tayal•310

  @rohantayalPosted 4 months ago

  Great job, Ivan!

  The only issue I encountered was that I could select the tip percentage only after entering the number of people to split the bill.

  0
• 

  P

  Srijan Manandhar•470

  @srijanssSubmitted 6 months ago

  What are you most proud of, and what would you do differently next time?

  • I tried using web components to build this project.
  • Encapsulating HTML, CSS and Javasript into one component and making it reusable made me try web components.
  • And important thing was I can use any class names in this component and it will not affect the styles of main page.
  • However, CSS variables defined in main file were accessible which was very helpful. I didn't have to redefine it in my component's CSS.

  What challenges did you encounter, and how did you overcome them?

  • I had decided to use web components, but I was not okay with adding css in javascript files.
  • Finally, I found a solution that vite provides to import css inline as strings. That way I was able to create separate css files and import it into my components javascript.

  What specific areas of your project would you like help with?

  Open for feedback

  

  Time tracking dashboard using Mobile first layout

  1

  20
  

  P

  Rohan Tayal•310

  @rohantayalPosted 5 months ago

  Very well made. Well done

  1
• 

  1deadjoe•370

  @1deadjoeSubmitted 6 months ago

  What are you most proud of, and what would you do differently next time?

  I am proud that I was able to handle the form pretty well, taking into account almost all factors to be considered. I would begin my design with mobile first. It makes the whole process easier.

  What challenges did you encounter, and how did you overcome them?

  Figuring out how to scale the illustration with respect to the rest of the content was a bit challenging. I used breakpoints to fix this but it was not 100% effective. Any help or insight would be much appreciated

  What specific areas of your project would you like help with?

  Figuring out how to scale the illustration with respect to the rest of the content was a bit challenging. I used breakpoints to fix this but it was not 100% effective. Any help or insight would be much appreciated

  

  NEWSLETTER USING HTML, CSS, AND JAVASCRIPT

  1

  20
  

  P

  Rohan Tayal•310

  @rohantayalPosted 5 months ago

  Well done, very nicely crafted.

  What I would suggest improving the breakpoints between (min-width: 740px) and (max-width: 1119px). The "content" class is overflowing its container.

  0
• 

  induwara-thisarindu•190

  @induwara-thisarinduSubmitted 6 months ago

  What are you most proud of, and what would you do differently next time?

  I am most proud of almost everything

  What challenges did you encounter, and how did you overcome them?

  I had some trouble with styling the pop up the javascript was figured out but the styling gave me a hard time I googled it and came across a lesson in w3 schools and kind of figured it out in it but still not that good on mobile

  What specific areas of your project would you like help with?

  I would like help with the mobile design styling I can't seem to understand what's wrong I mean I think it's not bad but not good either so I can get some help on mobile code It would be helpful

  Thanks 😊

  

  Article Preview Component with HTML, CSS, JS

  3

  20
  

  P

  Rohan Tayal•310

  @rohantayalPosted 5 months ago

  Hi @induwara-thisarindu!

  Just check your code; nicely done and well-crafted. In the mobile layout, removing the "show" class from the ID "links" will ensure that the profile information is visible first, rather than the share section.

  0

  This comment has received 1 replyShow
• 

  alvarozama•360

  @alvarozamaSubmitted 6 months ago

  What are you most proud of, and what would you do differently next time?

  Not much to feel proud of this time around since I was barely able to complete the challenge and my solution is extremely far from perfect as evidenced by the various bugs I was unable to fix. As far as what I would do differently next time, I guess I'd try to organize my markup elements in a much more concise way that also allows to retrieve them from the DOM more coherently.

  What challenges did you encounter, and how did you overcome them?

  Lots of challenges, but the biggest one was basically making the share button display different things according to the viewport size. I was able to overcome this by using the window.matchMedia() method and assinging the value of a desired breakpoint to a variable which was later used on a function that would work differently based on wether or not the screen size matched the one assigned to the variable.

  What specific areas of your project would you like help with?

  While the solution to the problem previously outlined kind of worked, it only did so when loading the page on a certain screen size and sticking to it. Loading the page on a mobile display would make the share button work as long as one remained on that display. However, when trying to go from mobile to desktop display or viceversa, the behaviors of the button would overlap and the speech bubble meant for desktop display would show on mobile, or the SNS bar meant for mobile would show on desktop. I had no idea how to solve this problem and would appreciate some insights on what I coul do differently.

  

  Article preview component

  1

  00
  

  P

  Rohan Tayal•310

  @rohantayalPosted 6 months ago

  You could apply overflow: hidden to your relative-anchor class for mobile and tablet layouts.

  That solves the mobile and tablet layout but then we face the similar issue in desktop layout.

  You can check out my solution and see if it helps. I couldn't think of any other alternatives asie from modifying the entire HTML structure.

  0
• 

  P

  KL•290

  @TorHammSubmitted 7 months ago

  What are you most proud of, and what would you do differently next time?

  Learned to use sass

  What challenges did you encounter, and how did you overcome them?

  What specific areas of your project would you like help with?

  Why my background image doesnt load

  

  Testimonials grid section

  1

  50
  

  P

  Rohan Tayal•310

  @rohantayalPosted 7 months ago

  Hi TorHamm!

  Your background image is not loading because the path to the image is wrong.

  Try changing the url to this url("../images/bg-pattern-quotation.svg").

  Marked as helpful

  1
• 

  Jvilla825•90

  @Jvilla825Submitted 10 months ago

  having issues with the image uploading, when i open my project on firefox developer edition everything works and uploads fine... appreciate the feedback

  

  QR Barcode

  3

  30
  

  P

  Rohan Tayal•310

  @rohantayalPosted 10 months ago

  Your src is pointing to the wrong file.

  IT is this <img src="file:///Users/josuevilla/Desktop/Portfolio/QR%20FOLDER/image-qr-code.png" alt="qr"> now.

  But it should be <img src="./image-qr-code.png">

  0

  This comment has received 2 repliesShow