- I am glad I got to work with vanilla css again.
- Making the design up to par
- Training my eye to get a pixel perfect solution for designs.
Great solution overall but I noticed the second column of the table at the bottom of the solution isn't spaced correctly, I could not view the code from the repository to give an accurate solution but you can always try using a text align or maybe a margin to help position it properly.
I learned how to use media queries and font sizes using rem
What challenges did you encounter, and how did you overcome them?sizing for mobile views
What specific areas of your project would you like help with?I would like to be helped in making the page more responsive
I'm basically a learner as well but then I hope this insight will be useful: for the chrome browser dev tools or when you right click on the page and go to "inspect" you can see how the page will look on different screen sizes and the dimensions too and I believe that should help in setting the media queries, if you knew this already then sorry for your time regardless the project is absolutely fantastic . Commenting in your code really helps and enhances understanding also the code is very neat and readable!
starting from the mobile design to using media queries to make my desktop design has been an eye opener for me to designing better code. i might be a little bit rusty because this is my first media query page. please feel free to criticize. thank you for helping me grow on this internetful journey lol
Really nice and great work to be honest! From the eye test alone it looks fantastic but the only thing I could spot was perhaps it’d be better to give a little more margin between the sides of the botton and the walls (horizontally) and at the extreme last button I feel it’d be a good idea to give more margin so it does not look to cramped together.
Using React for this project.
What challenges did you encounter, and how did you overcome them?The responsiveness was a little bit tricky, but I was able to pull through.
What specific areas of your project would you like help with?The header-image
doesn't seem to change according to the function, and I don't know why. Or maybe it changes, but I just don't see it. Some help would be greatly appreciated.
Great work really ! Although I believe in your solution the “Add to cart” button could use a little more margin below so there’s some space between the bottom and the button, I believe this will give it an overal cleaner look.
I reviewed the HTML and CSS code, amazing work really and definitely learnt a lot from how well you structured your code, super neat and very readable also with your choice of elements especially for the card contents, the attribution was also a really nice touch and that you added the favicon (I omitted it) shows you have great attention to detail. Only downside is I believe you omitted the active states for this challenge: there is a hover effect on the main heading which should change the color to the background color and also make the cursor a pointer as well as an increasing box shadow, this i believe was an omission as you have to check the styles.md file and also look at the design pictures to see there is an active state for this challenge, regardless I wholeheartedly believe this is fantastic work !
If I'm correct and your solution is on the left labelled "solution" I think the overall design could be centered better. That aside everything else looks amazing and I can tell you used exactly the same color schemes, I had some issues there but I was eventually able to work it out.