Skip to content
OverviewSolutions
7
Comments
6
Rinel
@rineliniguezsosa

All comments

  • Rinel•120
    @rineliniguezsosaPosted 3 months ago

    I really liked your work but these are the only points that caught my attention

    • in desktop development the card karma appears stuck in the Windows taskbar, perhaps a lower margin would have helped
    • in the header the html p elements could perhaps have been h1, h2 elements since they represent the title and subtitle
    • in the images set the title alt
    • In the mobile responsive design the media query was from 375px. When adjusting the browser window to certain dimensions, some elements do not adapt correctly and may be cut off.
    0
  • Rinel•120
    @rineliniguezsosaPosted 4 months ago

    I liked your work, these are the only points of observation

    • in the html
    • use article instead of the containing div element
    • don't use div elements for texts
    • The mobile design is good but the texts and the button may need more detail
    1
  • Pauljd1•80
    @Pauljd1Submitted 4 months ago
    What are you most proud of, and what would you do differently next time?

    .

    What challenges did you encounter, and how did you overcome them?

    .

    What specific areas of your project would you like help with?

    Spacing and lining up the bottom part with the nutrtion, I feel like I hacked it to make it work.

    Omelette-Challenge-Soloution

    1
    Rinel•120
    @rineliniguezsosaPosted 4 months ago

    I liked your work but these are the only points I would take into account.

    *in the html maybe you would have used an article instead of the container div, table instead of div

    • mobile design missing
    • the div named horizontal-line could have been a container div which could have had a border-bottom
    • main html ..
    Marked as helpful
    0
  • Rinel•120
    @rineliniguezsosaPosted 4 months ago

    I liked your work, maybe I need to make the card element higher

    0
  • Ali Alomar•20
    @KingSlayer3xSubmitted 4 months ago
    What challenges did you encounter, and how did you overcome them?

    Items positioning was kind off tricky.

    What specific areas of your project would you like help with?

    Using Flex and grid system for better design.

    HTML, CSS, responsive design, Second challenge.

    2
    Rinel•120
    @rineliniguezsosaPosted 4 months ago

    In your main container, align the items to the center and justify the content to the center in the same way. In the figma file, the text size, the internal padding, and the dimensions of the image appear.

    0
  • Rinel•120
    @rineliniguezsosaPosted 4 months ago

    In the main container, align the items to the center and justify the content to the center in the same way

    0