@CesarGMEFASubmitted over 2 years ago
what do you think about it?
radriann
@radriannAll comments
- @radriannPosted over 2 years ago
It's perfect!
I don't think any changes are necessary, although you could make the card smaller, however, the design is very well done, congratulations!
But you should change the attribution div to a footer, this is because when reporting, FrontEnd Mentor takes into account the use of Semantic HTML when structuring the page.
Marked as helpful1 - @Briancarlo24Submitted over 2 years ago
Please check my code. I believe I have improved with coding since I first started. I just want to know what you would have done differently with this challenge?
@radriannPosted over 2 years agoIt's a very good design but you should lower the font.
The background color is also missing, and so that the accessibility report does not come out, this is because FrontEnd Mentor when generating the error and accessibility report, takes into account that you use semantic tags, I recommend changing the div of the attribution by a footer or include it within the main.
Hope my tips help you and enjoy coding ^_^
Marked as helpful0 - @soloProgaSubmitted over 2 years ago@radriannPosted over 2 years ago
Hi! Your design is incredible, very good job. Some things you could improve:
1- In the mobile version, your design looks somewhat unfocused, I recommend you use margin, padding or encapsulate everything in a container and use flex positioning in the column direction when it is mobile.
2- The container div should be changed to a main or a section, because when generating the accessibility report, Frontend Mentor takes into account the semantic HTML.
3- The icons of social networks, you could make them bigger and add active states or "hovers"
4- The same with the button.
I hope my feedback will help you keep improving ^-^ have a nice day and enjoy coding
0 - @DrunkenNeoguriSubmitted over 2 years ago
(I translated the sentences into English using 'translate.google.com'. Please understand if there are any strange grammar.)
Hello, I'm uploading a challenge after a long time! This is the 12th challenge!
I started this challenge because I thought it was similar to the previous challenge 'ping coming soon page', but it was more difficult than I thought.
First of all, I think the arrangement of input fields and buttons is not neat. Also, I am concerned that the 'paragraph' added in case of an input error appears to be pushed up a little.
Javascript has only just begun to study, so the use of events and functions does not seem to have been written smoothly, so I feel frustrated.
I have a lot of thoughts about this and that, but I'm going to be satisfied with what I've done for now! It's still March, so I'll have to study JS a little more and try again!
Thank you for watching! > ▽<)/ If you have any other advice, please feel free to tell me!
@radriannPosted over 2 years agoHi! I hope you are having a good day. The project looks pretty good, when I tried it it was a mess, so I decided to try others. Some recommendations I have:
1- In the mobile resolution, the attribution is between the input and the paragraph, if you have a hard time positioning it, I recommend you delete it.
2- You should add a color for when the user enters a valid email, of course, that later when you study more JS! You will see that it will be easy for you once you practice validations and conditions.
3- It is impossible to achieve a pixel perfect design, so if you feel that certain elements are poorly positioned, leave your work as it is, rest and see the results. You will see how in reality that poorly positioned element does not really harm the final design.
Without further ado, I hope you have a good day and enjoy coding! ^-^
0 - @aiacySubmitted over 2 years ago
I definitely see that dark background behind the card and I'm wondering on how to do that with CSS? A separate background div with a drop shadow on the card?
@radriannPosted over 2 years agoHi!! I hope you have a good day, your project turned out great! Here I give you some recommendations in case you like to work on them ^-^:
1- The accessibility problem is due to the fact that the attribution of the challenge is outside of a semantic label. For example: <main>. I recommend changing the attribution div to a footer.
2- The letters of the attribution are in black, placing them with a white color or #fff would be better.
3-The background you are referring to is a box-shadow, I recommend you use the "box-shadow-generator" tool if you have trouble working with it.
Without further ado, I hope you have a great day!
1 - @bmhuyquoc104Submitted over 2 years ago
Please leave any advices so that I can improve my skills in front end development
- @nonamehzSubmitted over 2 years ago
Another challenge :)
- @Git-LuxSubmitted over 2 years ago
My second challenge on this site. Hope I did good. Please leave feedback and tips. Thank you fellow devs :)
@radriannPosted over 2 years agoVery well done! Some recommendations would be to add alternative text to images in more descriptive ways, this has to do with accessibility.
Also take into account the semantic HTML, that is, tags such as figure, main, etc.
Keep it up, have a nice day ^-^
Marked as helpful1 - @DAST-87Submitted almost 3 years ago@radriannPosted almost 3 years ago
Good job with this challenge! Some recomendations: The position of attribution, you can use the {position: absolute} for centrate it in bottom. Some alt attributes are empty, you shouldn't put them if you won't put anything in them. The hover icon can be reduced and it would look much better, plus a small transition of a few seconds can be added so that the change is not so abrupt.
Congratulations on completing the challenge ^ - ^ keep coding and have a nice day
Marked as helpful0
