QR code component solution

Community feedback

• 

  radriann•150

  @radriannPosted over 2 years ago

  It's a very good design but you should lower the font.

  The background color is also missing, and so that the accessibility report does not come out, this is because FrontEnd Mentor when generating the error and accessibility report, takes into account that you use semantic tags, I recommend changing the div of the attribution by a footer or include it within the main.

  Hope my tips help you and enjoy coding ^_^

  Marked as helpful

  0

  ---

  

  Brian Carlo Birondo•320

  @Briancarlo24Posted over 2 years ago

  @laindomJS I didn't know that was the accessibility report was all about. Thanks I'll implement that for sure.

  0
• 

  vcodey•270

  @v-codeyPosted over 2 years ago

  Hi @Briancarlo24, Really good job on the challenge, Just few things you may haven't done right

  • size of the card, font etc. is much bigger then the provided design
  • body background color isn't set
  • main container needs to white too, else its taking body background color.

  that was my few observations. Happy Coding

  Marked as helpful

  0

  ---

  

  Brian Carlo Birondo•320

  @Briancarlo24Posted over 2 years ago

  @v-codey I'm using free account so I don't really have the exact size.

  thanks though. I appreciate this kind of comment :D

  0

  

  vcodey•270

  @v-codeyPosted over 2 years ago

  @Briancarlo24 I'm also using the free account, I didn't meant you should create this with exact dimension, mine solution isn't exact either. Just eyeball the width height with provided design image (use desktop-design.jpg).

  also I forgot to mention,

  change attribution section from div to footer i.e.

  <footer class="attribution">
    Challenge by
    <a href="https://www.frontendmentor.io?ref=challenge" target="_blank"
    >Frontend Mentor</a
    >. Coded by
    <a href="https://github.com/Briancarlo24">Brian Carlo Birondo</a>.
   </footer>```
  

  Marked as helpful

  0