mobile first using HTML and CSS

Community feedback

• 

  radriann•150

  @radriannPosted over 2 years ago

  Very well done! Some recommendations would be to add alternative text to images in more descriptive ways, this has to do with accessibility.

  Also take into account the semantic HTML, that is, tags such as figure, main, etc.

  Keep it up, have a nice day ^-^

  Marked as helpful

  1
• 

  Abdul•8,540

  @SamadeenPosted over 2 years ago

  Great Work Mate.. Nice Attempt Challenge also.. I'd suggest you use <main class="container"> instead of <div class="container">.. Secondly to add an alternative text to your images for screen readers. Overrall You did nicely.. Cheers Mate

  Marked as helpful

  1
• 

  Shahin NJ•1,190

  @SJ-NosratPosted over 2 years ago

  Hi Luka, Awesome job on this challenge. The page responds perfectly between mobile-view right up to desktop sizes. I was looking at the Accessibility Issues generated by the report, find below some tips:

  1. Try and change the <div class="container"> to <main class="container">;
  2. You can use the <figure>tag instead of the <article> tag since you're wrapping <img> (images);
  3. Wrapping the <h1> tag in a <header> tag would be useful to screen-readers.

  The above tips follows Semantic HTML, since we're trying to give meaning to how we section off our content: you can read more about it here.

  Best of luck on your journey! You're doing great!

  Marked as helpful

  1

  ---

  

  Luka Velijević•70

  @Git-LuxPosted over 2 years ago

  @SJ-Nosrat thank you for taking the time to review and give feedback, really appreciate it :)

  1