Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • 99Abdelβ€’ 10

    @99Abdel

    Submitted

    What are you most proud of, and what would you do differently next time?

    i did not know how to center exactly the box in the page and make it parametrizable in order to get the sizes correct for the desktop and phone at once

    What specific areas of your project would you like help with?

    how to position correctly objects without being only rough by eye

    pjtetedeβ€’ 10

    @pjtetede

    Posted

    Hi there, as much as I'd love to help, the links to your site and code are not working. Please let me know when you've gotten them back up so I can give some tips.

    0
  • mr-sv3nβ€’ 10

    @mr-sv3n

    Submitted

    What are you most proud of, and what would you do differently next time?

    It is my first time, that I was building a mini-project with HTML and CSS, so I am proud, that I hit that first milestone. Things I would like to do differently next time: -Learn more about Figma, so I can better plan my site -Lean more about measurement units, so I can work in a more scalable manner -Use Flexbox

    What challenges did you encounter, and how did you overcome them?

    -I spent most time to wrap my head around grits and different ways they can be build depending on the need.

    pjtetedeβ€’ 10

    @pjtetede

    Posted

    Welldone, this is a nice one, and congrats on your milestone. You can only get better from here.

    I noticed that you mentioned wanting to learn more about Figma:

    I love the fact that you tried using grids even though it wasn't easy for you, that how one really learns and grows. The following might help when it come to grid:

    I hope this resources would be helpful on your journey towards greatness.πŸ‘‹πŸ½πŸ‘‹πŸ½πŸ‘‹πŸ½

    0
  • P
    Sam Hookerβ€’ 450

    @35degrees

    Submitted

    What are you most proud of, and what would you do differently next time?

    The BEM syntax was helpful and I can benefit from my structured, readable code.

    What challenges did you encounter, and how did you overcome them?

    pseudo elements and BEM were the biggest hurdles.

    pjtetedeβ€’ 10

    @pjtetede

    Posted

    Nice one here, welldone! This looks quite nice, but I have a couple of suggestions that might make it better.

    • Using semantic HTML such as a <main> tag inside the <body> of your HTML is a best practice because it clearly identifies the main content of your page. Inside the <main> tag you could then us something like an <article> tag and then instead of just using the <div> tag every where, you could use other semantic tags like <header> and <footer> inside the article tag. This helps with accessibility and improves how search engines understand your content. Check here to understand Semantic HTML more
    • I also noticed that the card was not properly centered. An easy way to center an element in its parent is to set its parents display to flex display:flex;, justify the parents content to the center justify-content: center; as well as align-items to center align-items: center;. This would work especially if its the only child of its parent and its parent has a fixed height.

    Your code :

    body {
    	font-size: 18px;
    	font-family: 'Outfit', sans-serif;
    	height: 100vh;
    	width: 100vw;
    	overflow: hidden;
    	display: grid;
    	place-items: center;
    	background-color: var(--very-dark-blue-main);
    }
    

    What I explained above:

    body {
    	font-size: 18px;
    	font-family: 'Outfit', sans-serif;
    	height: 100vh;
    	width: 100vw;
    	overflow: hidden;
    	/* display: grid; */ display: flex;
    	/* place-items: center; */ justify-content: center;
            align-items: center;
    	background-color: var(--very-dark-blue-main);
    }
    

    With the above, the card would automatically be centered on the page. Here is a comprehensive and very helpful article on flexbox

    I hope these points would be helpful. Welldone and keep making progressπŸ‘πŸ½πŸ‘πŸ½πŸ‘πŸ½

    0
  • pjtetedeβ€’ 10

    @pjtetede

    Posted

    Welldone, this was a nice one. You used Semantic HTML and I like the hover effect you added. Your work is as close to the design as can be.

    Again, welldone.

    0