Latest comments
- @PremKhodke-99Submitted about 1 year ago@pertrai1Posted 9 months ago
This is great work you have done. It basically aligns with the layout given and has clean markup for both the HTML and CSS. Well done!
0 - @ajibade-devSubmitted over 1 year ago@pertrai1Posted over 1 year ago
I like your solution more than the actual design. Very well done.
0 - @pertrai1Submitted almost 2 years ago@pertrai1Posted almost 2 years ago
Still working on my code reusability, mainly with CSS. Wondering if putting a lot of values in variables would be helpful or not. Same with properties that are shared across rules, would it be better to combined the two or more rules, or create a helper rule?
0 - @JCastelli12Submitted almost 2 years ago@pertrai1Posted almost 2 years ago
The code I looked at looks great. I did look and see that there is a 404 for the font location. Maybe changing
src: url(/assets/fonts/Inter-VariableFont_slnt\,wght.ttf);
tosrc: url(assets/fonts/Inter-VariableFont_slnt\,wght.ttf);
where/assets
becomesassets
without the leading/
?Marked as helpful1 - @BeziesSubmitted almost 2 years ago@pertrai1Posted almost 2 years ago
Good work with the solution. When you say that you are having trouble with the size of the input and button, do you mean that it would be nice to only write code once and not have to duplicate for both? If so, you could take what is used for both of them and combine into one rule, i.e.
#email, #sub { padding: 15px 20px; }
Then you can remove that from each individual rule. This way, you can change the value once and both will pick it up.
I hope that is what you meant when you need to find a way to have them the same size.
Marked as helpful0 - @codeguy9Submitted almost 2 years ago@pertrai1Posted almost 2 years ago
Great work on the solution you have come up with.
Check in your JS and notice that you are using
querySelector
for theselected-tab
, but there are multiple elements in the DOM that have this class. Because of this you will need to usequerySelectorAll
and then loop over each of them to add the classinactive
. See if that helps get you going in the right direction.Marked as helpful0