Skip to content
OverviewSolutions
6
Comments
74
P
Jessica
@perezjprz19

All comments

  • Jessica•880
    @perezjprz19Posted almost 3 years ago

    I found this article very helpful I'm understanding how the different values work.

    Marked as helpful
    1
  • Adam Elitzur•110
    @AdamElitzurSubmitted almost 3 years ago

    Is there anything that I should be doing differently? Maybe with the units, is it bad to hardcode in 25 ems just because it looks right?

    QR Code Component

    2
    Jessica•880
    @perezjprz19Posted almost 3 years ago

    So your image is actually huge on my phone and I think that is because you hard coded the width and the height, so it's not adjusting to my screen size and it's overflowing.

    Could you try playing around with max-width instead of width?

    I also didn't add a height to mine. I let the content in the card decide the height.

    Here is my solution in case you want to check it out.

    Marked as helpful
    1
  • Jessica•880
    @perezjprz19Posted almost 3 years ago

    Você é muito bem-vindo!! Fico feliz em poder ajudar.

    Marked as helpful
    0
  • Adriana Silva Almeida•50
    @Adriana2710Submitted almost 3 years ago

    Hello everyone! I've just completed the "QR code component" challenge and to be honest I don't know what I did wrong but looks like the size of the page is different. I'm a newbie in Front End, just finished one course of HTML5 and CSS basics, if someone has some time could you please give some tips on what I did wrong, any feedback and suggestions on how I can improve are very welcome!

    Responsive web page

    3
    Jessica•880
    @perezjprz19Posted almost 3 years ago

    Hmm... your solution looks great. Just try giving the body

            height: 100vh;
       display: flex; 
       justify-content: center; 
      align-items: center;
    Marked as helpful
    1
  • Jessica•880
    @perezjprz19Posted almost 3 years ago

    Everyone is at different levels in their learning journey, but with that being said, you get out of these challenges what you put in to them, In my opinion.

    Eventually these challenges will be used to make it easier for us to find jobs through the creation of the hiring platform. So if that's your goal, then I'd recommend making sure your solutions are as good as you can make them.

    If that's not your goal, other coders might still see your submitted code and use it as a learning resource. So that's something to consider I think.

    Marked as helpful
    0
  • Daniel•110
    @xBuzAxSubmitted almost 3 years ago

    Hi,

    This is my second project made with frontend mentor and I am very satisfied.

    Do you think I could improve something? Write, comment. I will accept any criticism :)

    Stats preview card component

    3
    Jessica•880
    @perezjprz19Posted almost 3 years ago

    The color for the attribution is illegible, so you might want to consider changing the color since they would not meet accessibility standards.

    I would recommend using opacity and mix-blend-mode to get the color of the overlay closer to the design.

    Marked as helpful
    1
  • Jessica•880
    @perezjprz19Posted almost 3 years ago

    👋

    Looks good, but I think you need a bit of margin around your card so that it doesn't touch edges. Card touches top and bottom sides on mobile.

    Marked as helpful
    1
  • Jessica•880
    @perezjprz19Posted almost 3 years ago

    👋

    I used max-width for the card and the image, rather than giving it an explicit width value.

    You can see my solution here

    0
  • Jessica•880
    @perezjprz19Posted almost 3 years ago

    Hey there! 👋 it looks like the link to your code isn't working. Also adding a little bit of padding to the bottom of the card will give it a little more space between the text and the edge of the card, as in the design.

    Overall, good job!

    0
  • t•70
    @newbloomSubmitted almost 3 years ago

    I don't know if I'm using media queries correctly. Should I be building the bulk of my CSS for mobile purposes, and then creating a media query with the necessary changes to the CSS for desktop view? Or should I have individual queries for each?

    I'm not sure I've implemented the desktop to browser switch effectively.

    Stats Preview Card Component

    1
    Jessica•880
    @perezjprz19Posted almost 3 years ago

    That's they way I do it, at least. I build all my code for mobile and then start increasing my viewport width slowly. When things start to look weird, I tweak my code and add media queries of necessary.

    You can see my solution here

    Marked as helpful
    0
  • Tobias•100
    @ToHXSubmitted almost 3 years ago

    Hi everyone,

    I'm not completely happy with my card-shadow. I did use a website (https://getcssscan.com/css-box-shadow-examples) for that but you can see that on the QR Code img it doesn't fit.

    Apart from that, I was this time much faster in building my solution as this is my 2nd project. :)

    QR code component challenge

    3
    Jessica•880
    @perezjprz19Posted almost 3 years ago

    Hi ToHX!

    I think your shadow looks fine based on the challenge comparison. However, the card does touch the edges of my phone screen so I can't really see the shadow. Some margin could help with that.

    Marked as helpful
    0
  • Jessica•880
    @perezjprz19Posted almost 3 years ago

    Your project looks good. Keep up the good work!

    0