Let me know what I can do to improve my code
Parvathy Vazhoor
@parvathyvdAll comments
- @chrisHebs23Submitted about 2 years ago@parvathyvdPosted about 2 years ago
Hi Christopher
First of all good work. One thing I notice is that the dropdown menu is not visible on large screens. I thought of mentioning about it.
Thanks
Marked as helpful0 - @liamchivers23Submitted over 2 years ago
Updated solution after feedback.
@parvathyvdPosted over 2 years agoHi Liam,
Nice Work
You need height and width on the circle to make the border radius a perfect circle. Add below to your list-item will fix the issue for you.
.list-item { height: 4rem; width: 4rem; display: flex; justify-content: center; align-items: center; }thanks
Marked as helpful1 - @hellomarinaSubmitted over 2 years ago
-I had trouble trying to align the buttons of the last box. The last box have an extra line of text and because of that the button of that card is more down. I couldn't figure it out how to fix that. I tried a few stuff but nothing worked so I will really appreciate some feedback about this issue!
@parvathyvdPosted over 2 years agoHi,
Instead of giving height and width to the individual boxes give width to the parent.
cards { display: flex; justify-content: center; align-items: center; max-width: 50rem; margin: 0 auto; /* min-height: 100vh; //remove this } also remove width and heights from the boxes .box-1 ,2, 3{ /* height: 450px; / / width: 250px; }
That will fix your problem. Always try to use width instead of height. Let the padding, margins define their height. Hope this helps.
Thanks
Marked as helpful1 - @parvathyvdSubmitted over 2 years ago
I couldn't able to change the hover color of the social media icons even though i changed it on hover in the css. I believe may it because the font icon itself? I took them from font-awesome-icons. Please feel free to let me know what's wrong with it
Thanks
@parvathyvdPosted over 2 years agooh ..Thanks a bunch. I might have accidentally added that in the pseudo class. Thanks for pointing it out. That was fast! I really appreciate it.
Thanks :)
0