Intro section with dropdown navigation
Design comparison
Solution retrospective
Let me know what I can do to improve my code
Community feedback
- @AdrianoEscarabotePosted about 2 years ago
Hi Christopher Heberden, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:
Every html document must contain a main tag, to inform what is the main content of the page, as this page is a complete page, that is, it has a header a main and the footer, wrap the main content with the main tag , for users who use screen readers, to be able to understand what the main content of the screen is!
@media only screen and (min-width: 768px) .text-container h1 { font-size: 92px; }
Avoid using
px
, If your web content font sizes are set to absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. if you want to keep using px for development and then format the whole code to rem, you can use this vscode extension: px to remThe rest is great!
I hope it helps... 👍
Marked as helpful0@chrisHebs23Posted almost 2 years ago@AdrianoEscarabote I am doing great, thanks, and yourself?
I want to thank you for your tips; they are really helpful. I will implement them in this project and other projects going forward.
You are a great help! Thanks again
1 - @parvathyvdPosted about 2 years ago
Hi Christopher
First of all good work. One thing I notice is that the dropdown menu is not visible on large screens. I thought of mentioning about it.
Thanks
Marked as helpful0@chrisHebs23Posted almost 2 years ago@parvathyvd
Thank you for pointing that out. I will go ahead and fix that. Your comment was very helpful.
Thank you!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord