Skip to content
OverviewSolutions
19
Comments
1808
P
Patrick
@palgramming

All comments

  • Patrick•14,265
    @palgrammingPosted over 3 years ago

    Looks Good very nice job

    Marked as helpful
    1
  • Patrick•14,265
    @palgrammingPosted over 3 years ago

    When the user selects a region from the drop-down the list does not show an option has been selected. The countries seem to update but there is no conformation that the user selected the correct region

    Marked as helpful
    0
  • Patrick•14,265
    @palgrammingPosted over 3 years ago

    you should change you body background styles to this

    background: url('./images/pattern-background-desktop.svg');
background-color: var(--Pale-blue);
background-size: 100vw 40vh;
background-repeat: no-repeat;
    Marked as helpful
    1
  • Amon•2,560
    @A-amonSubmitted over 3 years ago

    Any feedback is welcome~

    HTML, SCSS

    1
    Patrick•14,265
    @palgrammingPosted over 3 years ago

    you should change the background-size on the body tag from 100% to '100% 40%or100vw 40vh`

    Marked as helpful
    0
  • Patrick•14,265
    @palgrammingPosted over 3 years ago

    you should limit the use of the . key so the user cannot enter a number like this 1.2.3.4.5.6.7.8.9

    0
  • Patrick•14,265
    @palgrammingPosted over 3 years ago

    The main thing in you nav that is no state change for the user to know what page they are on. Some how you need to highlight to the user what page is currently selected

    0
  • Patrick•14,265
    @palgrammingPosted over 3 years ago

    you should change the background size on your body tag from contain to 100vw 40vh

    Marked as helpful
    0
  • Daniel Haro•50
    @o0oDanielHaroo0oSubmitted over 3 years ago

    I ran into a problem with the border-radius. Starting at 1055px screen width it seems to flatten out and ends up looking like a regular box. I can't seem to find the source of this issue. Any help would be appreciated!

    HTML, CSS, Flexbox -- (Need help with border-radius)

    2
    Patrick•14,265
    @palgrammingPosted over 3 years ago

    well you you need to put the border raidus on the corners of your cards that need them

    Put this on your orange card border-radius: 20px 0 0 20px; then look at how the dark cyan card compares to the results on the orange

    the key is you have to transition the border radius corners on the cards depending if it is the mobile or desktop layouts

    Marked as helpful
    1
  • Patrick•14,265
    @palgrammingPosted over 3 years ago

    you need to put a controlled height on your card container you currently had 100vh but I put 60vh on it in web dev tools and then one each of your individual cards put a height of 100% on each of them

    thank should get you close

    Marked as helpful
    0
  • Jeff•80
    @jcombs0929Submitted over 3 years ago

    I decided to use svgs for the images, and they can be confusing. Please let me know if I utilized these incorrectly. Thank you!

    Order Summary – Flexbox and SVG

    2
    Patrick•14,265
    @palgrammingPosted over 3 years ago

    well just attach the SVG main background to the body tag in your css you do not need all the extra effort and code to when you can use use this https://www.w3schools.com/cssref/css3_pr_background.asp

    Marked as helpful
    0
  • Patrick•14,265
    @palgrammingPosted over 3 years ago

    maybe start by attaching the main background to the body tag in the css and not using a img tag to insert it in the page https://www.w3schools.com/cssref/css3_pr_background.asp

    0
  • Patrick•14,265
    @palgrammingPosted over 3 years ago

    Looks Nice. Good Job 🌟🌟🌟🌟🌟

    Marked as helpful
    0