R A H U L
@owlbuntAll comments
- @omlan99Submitted 9 months ago@owlbuntPosted 9 months ago
Everything seems fine you can center the element by adding display :grid and pplace-items:center to body .
1 - @eldon6219Submitted 10 months ago
first time doing a challenge here ! so excited to learn more and do more challenges
@owlbuntPosted 10 months agoCongratulations On Completing this challenge,
Here are some improvements you can make like Insted of using
100vh
use100dvh
to make your website more responsive.and you can delete all the unnecessary files which is not required after the challenge to keep your code and GitHub clean like the
design
folder .Mark This as Helpful If It's Help
Marked as helpful0 - @addiellucena94Submitted 10 months ago@owlbuntPosted 10 months ago
There are some improvements you can make like Insted of using
100vh
use100dvh
to make your website more responsive.you can delete all the unnecessary files which is not required after the challenge to keep your code and GitHub clean like the
design
folder .you can add a
js function
which allows you to open a single question at a time close the others for reference you can checkout my code.Mark This as Helpful If It's Help
Marked as helpful0 - @gmenesesdevSubmitted 10 months ago@owlbuntPosted 10 months ago
There are some improvements you can make like Insted of using
100vh
use100dvh
to make your website more responsive. and you can delete all the unnecessary files which is not required after the challenge to keep your code and GitHub clean like thedesign
folder .Mark This as Helpful If It's Help
Marked as helpful1 - @xiAvalonSubmitted 10 months ago@owlbuntPosted 10 months ago
There are some improvements you can make like Insted of using
100vh
use100dvh
to make your website more responsive. And to center a <div> you can also usedisplay:grid; place-items: center;
. and last you can delete all the unnecessary files which is not required after the challenge to keep your code and GitHub clean like thedesign
folder .Mark This as Helpful If It's Help
Marked as helpful0 - @asaga22Submitted 10 months ago
What did you find difficult while building the project? creating gradient
@owlbuntPosted 10 months agoDesign Seems Good And Ig We can reduce the use of js where things can be done using html and css only to increase the page speed which also effect in SEO and also you don't have to add fonts additionally there is an
font folder
which includes required fonts in assets folder.0 - @iamthulasinathSubmitted 10 months ago@owlbuntPosted 10 months ago
Designs are not similar at all try again and check the design folder and try if you find any difficulty ask me anytime. 😊
0 - @varadpalSubmitted 10 months ago@owlbuntPosted 10 months ago
Ah, nice try! Please make it responsive for mobile devices as well. Additionally, center it by using
display: grid; place-items: center;
with100dvh
and100dvw
on the body.0 - @jcfrancisco17Submitted 10 months ago
- @GudelisSubmitted 10 months ago
First time doing accordion any feedback will be appreciated
@owlbuntPosted 10 months agoEverything is fine and i checked that you added a function which allows to open only question at a time and that's good only make it responsive for mobile device otherwise perfect. 🤗
Marked as helpful0 - @birdbirdmurmurSubmitted 10 months ago@owlbuntPosted 10 months ago
Congratulations 🎉 on completing this challange.
I have some suggestions for you 📌
-
Always use dvh and dvw instead lf vh and vw for height and width property like this
100vh > 100dvh
-
Delete Unnecessary Files After Completing the challenge like
design folder
to keep your GitHub clean
1 -
- @ironestSubmitted 10 months ago
I am happy to receive any feedback :-)
@owlbuntPosted 10 months agoUse
dvh and dvw
instead of vh and vw to make more responsiveMarked as helpful0