Results summary component using Flexbox, Javascript, jQuery
Design comparison
Solution retrospective
What did you find difficult while building the project? creating gradient
Community feedback
- @danielmrz-devPosted 10 months ago
Hello @asaga22!
Your solution looks excelent!
I have just one suggestion:
- In order to make your HTML code more semantic, don't skip heading levels - start with
<h1>
, then use<h2>
, and so on. Unlike what most people think, it's not just about the size and weight of the text.
π The
<h1>
to<h6>
tags are used to define HTML headings.π
<h1>
defines the most important heading.π
<h6>
defines the least important heading.π Only use one
<h1>
per page - this should represent the main heading/title for the whole page.This change has little or not effect at all on the project, but it makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, you did a great job!
0@asaga22Posted 10 months agoHi @danielmrz-dev,
Thank you very much for your insightful feedback! I will update project according to your suggestions.
1 - In order to make your HTML code more semantic, don't skip heading levels - start with
- @owlbuntPosted 10 months ago
Design Seems Good And Ig We can reduce the use of js where things can be done using html and css only to increase the page speed which also effect in SEO and also you don't have to add fonts additionally there is an
font folder
which includes required fonts in assets folder.0@asaga22Posted 10 months agoHi @owlbun!
Thank you very much for your feedback! About the use of JS, in the Readme challenge, it instructs to
Use the local JSON data to dynamically populate the content
. So i was under assumption, in order to follow that particular instruction, can only be achieved with the use of JS. Do I understand that correctly? Kindly need your advise.0@owlbuntPosted 10 months agoyeah you can use js but using less js would be beneficial @asaga22
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord