Flexbox, Media Queries

Community feedback

• 

  Daniel 🛸•44,270

  @danielmrz-devPosted 10 months ago

  Hello @ironest!

  Your solution looks great!

  I have a couple of suggestions for improvement:

  • First: In order to make your HTML code more semantic, use <h1> for the main title instead of <span>. Unlike what most people think, it's not just about the size and weight of the text.

  📌 The <h1> to <h6> tags are used to define HTML headings.

  📌 <h1> defines the most important heading.

  📌 <h6> defines the least important heading.

  📌 Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

  • Second: Still about semantic HTML, use <main> to wrap the main content instead of <div>.

  All these tag changes may have little or no visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, great job!

  Marked as helpful

  0
• 

  Marcos Travaglini•4,840

  @BlackpachamamePosted 10 months ago

  Greetings! you have done a great job 😎

  📌 Some accessibility and semantics recommendations for your HTML

  • To improve the semantics of your HTML, you can change your <div class="card"> to a <main class="card"> and the <div class="attribution"> to a <footer class="attribution">
  • For mobile or tablet screens, the footer overlaps with the main by having a position: absolute. You should find a way to correct that.
  • The span tag is used to apply styles to a specific part of a text, so you have used it incorrectly. The texts in this case should be p or headings like h1, h2, etc.

  Marked as helpful

  0
• 

  R A H U L•360

  @owlbuntPosted 10 months ago

  Use dvh and dvw instead of vh and vw to make more responsive

  Marked as helpful

  0