All comments

• 

  Leo•40

  @0LeonelSubmitted about 1 year ago

  

  NFT Preview Card Component

  1

  30
  

  Oubaid•180

  @oubaidelmoudhikPosted about 1 year ago

  Hello! Great job on the project! I've got a couple of notes you might want to implement: -You're using a lot of divs and no semantic HTML, maybe try to swap the divs for the appropriate semantic HTML elements. The use of semantic HTML elements like <header>, <nav>, <main>, <footer>, etc., is beneficial for accessibility and helps screen readers understand the page's structure.

  • There is a <footer> tag outside of the body tag, you might want to take a look at it.
  • Favicon: The site includes a favicon for better user experience, but the "alt" attribute is missing on the favicon image. It's a good practice to include an "alt" attribute even for favicons. Great job again! and good luck on your journey.

  1
• 

  Yewande Adeyemi•110

  @WandesanguineSubmitted over 2 years ago

  

  Responsive CSS and HTML

  2

  40
  

  Oubaid•180

  @oubaidelmoudhikPosted over 2 years ago

  Good job on the challenge! I have a few improvement areas you could work on if you'd like: -Your main white background isn't showing, that's because your .container class got removed from the main element. -Also, to center everything on the page, try setting your body min-height to 100vh.

  Anyhow, great work! keep it up and good luck on your journey!

  0