Design comparison
SolutionDesign
Community feedback
- @oubaidelmoudhikPosted about 1 year ago
Hello! Great job on the project! I've got a couple of notes you might want to implement: -You're using a lot of divs and no semantic HTML, maybe try to swap the divs for the appropriate semantic HTML elements. The use of semantic HTML elements like <header>, <nav>, <main>, <footer>, etc., is beneficial for accessibility and helps screen readers understand the page's structure.
- There is a <footer> tag outside of the body tag, you might want to take a look at it.
- Favicon: The site includes a favicon for better user experience, but the "alt" attribute is missing on the favicon image. It's a good practice to include an "alt" attribute even for favicons. Great job again! and good luck on your journey.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord