Responsive CSS and HTML

Community feedback

• 

  Oubaid•180

  @oubaidelmoudhikPosted over 2 years ago

  Good job on the challenge! I have a few improvement areas you could work on if you'd like: -Your main white background isn't showing, that's because your .container class got removed from the main element. -Also, to center everything on the page, try setting your body min-height to 100vh.

  Anyhow, great work! keep it up and good luck on your journey!

  0
• 

  romila•3,570

  @romila2003Posted over 2 years ago

  Hi Yewande,

  Congratulations 🎉 on completing your second challenge, it was a great attempt. Some minor issues I want to address include:

  1. Within your img tag, you are missing an alternative text which is important for accessibility. If the image does not load, then users can still understand what the content of the image is. Also, the alternative text can help blind users using screen readers. The code will look something like this:

  <img src=".images/image-qr-code.png" alt="QR Code Image" class="image">
  

  2. It is best practice to wrap your code with the correct semantics. For the container, it should be wrapped within the main tag and for the footer, it should be wrapped within the footer tag.

  <main class="container"></main>
  <footer class="attribution"></footer>
  

  Overall, great attempt and wish you the best of luck for your future projects so keep coding 👍.

  0