Skip to content
OverviewSolutions
7
Comments
7
nilmus
@nilmus

All comments

  • Bruno514•100
    @Bruno514Submitted 5 months ago
    What specific areas of your project would you like help with?

    I would really aprecciate some feedback on my CSS class naming using BEM, as I'm still new to it.

    Responsive Testimonial Grid

    #bem#sass/scss
    1
    nilmus•100
    @nilmusPosted 5 months ago

    Much better than my solution, I don't think I'm in the position to give feedback

    1
  • nilmus•100
    @nilmusPosted 6 months ago

    I would focus on writing semantic HTML, instead of over-relying on div. Also, don't forget the alt attribute for images.

    1
  • nilmus•100
    @nilmusPosted 6 months ago

    I see that to switch from the mobile-image to the desktop-image, you used display: none inside your media query.

    This works, but note there is a better solution by using the figure element and giving it an img and a source, like so:

    <figure
    <source
        media="(min-width: 1024px)"
        srcset="images/image-product-desktop.jpg"
    />
    <img
        class="product-image"
	src="images/image-product-mobile.jpg"
	alt="perfume image"
    />
/>
    Marked as helpful
    0
  • Nalish•40
    @NalishSubmitted 6 months ago
    What challenges did you encounter, and how did you overcome them?

    My main challenge was integrating the fonts that were provided.I ended up working with the default font .

    What specific areas of your project would you like help with?

    I would really appreciate insight on working with fonts especially when the font folder is already provided. I would also love to learn how. to style the table.

    A recipe page

    1
    nilmus•100
    @nilmusPosted 6 months ago

    You can use @font-face to apply the provided fonts. MDN reference

    0
  • P
    Kishore Kongani•60
    @laxmikishore13Submitted 6 months ago
    What specific areas of your project would you like help with?

    I need help with whether the structure i am following is good for css and html, and any code improvements should i do?

    Social links Profile using HTML and CSS

    2
    nilmus•100
    @nilmusPosted 6 months ago

    Great job on the final result, it looks just like the design.

    Some things you could improve are:

    • you have not used <a> elements for the links
    • using a list element is preferred for a list of links, rather than the button elements you used
    • you could use semantic HTML instead of relying on div
    • in the CSS, instead of having a huge selector of h1, h2, h3, h4, h5, h6, p you could just apply those properties to the body selector
    0
  • Kalyan TR•40
    @tr-KalyanSubmitted 6 months ago
    What are you most proud of, and what would you do differently next time?

    Used my experience from previous project.

    What challenges did you encounter, and how did you overcome them?

    Alignment of author image which is svg file and the name

    What specific areas of your project would you like help with?

    Any suggestion to improve the readability of the code.

    Blog Preview Card

    1
    nilmus•100
    @nilmusPosted 6 months ago

    You could use a wider range of semantic tags, rather than only using <section>. For example: <header>, <footer>...

    0
  • nilmus•100
    @nilmusPosted 6 months ago

    /

    0