Submitted about 2 months ago
Social links Profile using HTML and CSS
@laxmikishore13
Design comparison
SolutionDesign
Solution retrospective
What specific areas of your project would you like help with?
I need help with whether the structure i am following is good for css and html, and any code improvements should i do?
Community feedback
- @nilmusPosted about 2 months ago
Great job on the final result, it looks just like the design.
Some things you could improve are:
- you have not used
<a>
elements for the links - using a list element is preferred for a list of links, rather than the
button
elements you used - you could use semantic HTML instead of relying on
div
- in the CSS, instead of having a huge selector of
h1, h2, h3, h4, h5, h6, p
you could just apply those properties to thebody
selector
0 - you have not used
- @Lukas3162000Posted about 2 months ago
First of all i really like that your card almost exactly fits the img provided, nice work! I also find the use of " transition: all 0.5s ease-out;" for the buttons really smooth :)
To improve accessibility for ppl. who need to access the web with screenreaders e.g. u could make your html semantic.
Hope this helped a little, keep up the good work!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord