Nikki

Latest comments

• 

  Wisllor PS•470

  @KevallionSubmitted over 1 year ago

  

  Meet landing page

  1

  10
  

  Nikki•160

  @nicolette-codesPosted 12 months ago

  Hi,

  I like that you html file is very clean and well structured.

  I think your css could be improved. My suggestions.

  1. Use CSS custom properties to make adjusting/changing of certain properties easier i.e. font color etc.
  2. Your purple button in the header section is broken on my screen because it has a fixed width

  width: 139px;
  

  3. Font sizing should ideally not be done with hard-coded px values

  0
• 

  DivasJaglan•170

  @DivasJaglanSubmitted 12 months ago

  What are you most proud of, and what would you do differently next time?

  Proud of completing this new task. Next time I will get more prepared for the grid layout.

  What challenges did you encounter, and how did you overcome them?

  I faced challenge in aligning the cards in the desired position for the desktop mode. The I used the chrome developer tools for help which came in so handy for that.

  What specific areas of your project would you like help with?

  I think my grid section need some more improvement in the media query. I am not that good in designing with grid at this moment. 🥲

  

  Responsive Testimonial Cards

  1

  40
  

  Nikki•160

  @nicolette-codesPosted 12 months ago

  Hello,

  I have a bit of advise for you.

  1. In your markup you do not use the main & section elements

  i.e. you could replace the <div class="container"></div> with this

  <main>
     <section class="testimonials">
          .... here goes the rest of the markup
     </section>
  </main
  

  2. Your img elements are missing text in the alt attribute.

  3. You should set a fixed with or better maximum width on your grid container for desktop version. Otherwise it won't stop growing in width and starts to look weird.

  Marked as helpful

  1
• 

  dcubic•330

  @dcubicSubmitted about 1 year ago

  What are you most proud of, and what would you do differently next time?

  I liked my feature layouts

  What challenges did you encounter, and how did you overcome them?

  I couldn't quite figure out how the box shadows worked. I also don't like the transition from mobile to desktop state. The expanded mobile state looks far too bulky and the shrunk desktop state looks too compressed. I think the only solution would be to use an entirely different grid layout for that middle transition stage, but the design didn't specify anything so I didn't bother.

  What specific areas of your project would you like help with?

  Nothing really

  

  Four Card Feature Section

  1

  40
  

  Nikki•160

  @nicolette-codesPosted about 1 year ago

  Nice work. Don't have any suggestions to improve your solution. Keep up the good work.

  0
• 

  Michael•80

  @vonsackerSubmitted about 1 year ago

  What are you most proud of, and what would you do differently next time?

  I think the responsiveness came out well, without using to much extra code

  What challenges did you encounter, and how did you overcome them?

  I had some issues with copying the layout of the text from the designs. After some trial and error it came out pretty close to the original

  What specific areas of your project would you like help with?

  I'm using a normalize.css file, but i'm not sure it's necassry. Also i'm not sure if i'm using spacing the right way fot the text.

  

  Responsive Product Card

  1

  40
  

  Nikki•160

  @nicolette-codesPosted about 1 year ago

  I received some feed earlier today that I found helpful, so I gonna copy it here.

  --variables: don't use color name for your variable

  :root{
     --Dark-Cyan: hsl(158, 36%, 37%);
     --Cream: hsl(30, 38%, 92%);
     --Very-Dark-Blue: hsl(212, 21%, 14%);
     --Dark_Grayish-Blue: hsl(228, 12%, 48%);
     --White: hsl(0, 0%, 100%)
  }
  

  what happened when your designer calls you and he will tell you that he wants color of the background change it to pink?

  --Cream: pink;
  

  It's better to names like this: primary, secondary, link-color, header-color, bg-color, text-color and so on.

  --bg-color: hsl(30, 38%, 92%);
  

  Marked as helpful

  1
• 

  Peter Bachman•200

  @PeterBachman100Submitted about 1 year ago

  What are you most proud of, and what would you do differently next time?

  Most proud of the table spacing at the bottom. Next time I would ask ChatGPT for ideas form the get go.

  What challenges did you encounter, and how did you overcome them?

  Getting the spacing right on the tables and the list items and markers was difficult. Persistence was key in figuring it out.

  What specific areas of your project would you like help with?

  Not a big deal, but the number 1 in the instructions list is different than the design doc despite being the same font, and I can't figure out why.

  

  Recipe Card

  1

  20
  

  Nikki•160

  @nicolette-codesPosted about 1 year ago

  Excellent work. I really like what you made here. Don't really have any tips to make it better. I especially like how efficient your CSS is, I have like 100 lines more in my solution.

  Keep up the good work!

  1
• 

  Michael•80

  @vonsackerSubmitted about 1 year ago

  What are you most proud of, and what would you do differently next time?

  It went pretty smoothly.

  What challenges did you encounter, and how did you overcome them?

  doubts about using list with tags or just buttons.

  What specific areas of your project would you like help with?

  Any feedback is more then welcome.

  

  Social links profile page

  1

  30
  

  Nikki•160

  @nicolette-codesPosted about 1 year ago

  Hey, I like your solution, good work.

  I don't really find much to critique. You could remove the empty header and the footer elements (content of footer is commented out ).

  I also agree with your choice of using a list with links in it. I think it's semantically the best way.

  Code on.

  2