Recipe page | HTML & CSS

Community feedback

• 

  Mirjax2000•720

  @Mirjax2000Posted about 1 year ago

  Hi i checked your code. You are using too much fixed values in pixels. Try to use REM, EM, WV units or percentages instead.

  If you hardcode it in to pixels, users with different default font size in their browser will see your page broken. We are in responzive and dynamic page time, all has to be fluid not fixed.

  Next big problem. You use height on every element. What happened, if you want to change some text in your paragraph with more words, or make it shorter? The text will overflow. And you have to go to css to find the problem. Dont use heights at all, web browser is smart. If you need some heights use min-height. Work with padding, line-heigts, or margins.

  next challenge you do, dont use heights and dont use pixels at all. challenge in challenge.

  --variables: dont use color name for your variable.

  	--rose-white: hsl(330, 100%, 98%);
  	--eggshell: hsl(30, 54%, 90%);
  	--grey: hsl(30, 18%, 87%);
  	--brown: hsl(30, 10%, 34%);
  	--charcoal: hsl(24, 5%, 18%);
  

  what happened when your designer calls you and he will tell you taht he wants color of backround change it to pink?

  --rose-white:pink
  

  use better naming technique, primary, secondary, link-color, header-color, bg-color, txt-clr and so on.

  you also try using BEM to name your classes. The best values for using BEM is with some preprocessors, like Sass, Less. It is another level and it will help you to thing like a real programmer. It is basic start to be more advanced.

  Continue, and i want to see your another challenges.

  Marked as helpful

  1