All comments

• 

  Burak• 10

  @karayanikburak

  Submitted over 1 year ago

  

  QR Code Component with HTML and CSS -frontendmentor.io

  2

  40

  

  Michael Sutcliffe• 40

  @msutcliffe2303

  Posted over 1 year ago

  Hey, Congratulations on completing the task!

  Theres a few things you could change in this, the first would be using flex or grid to center the content for you. Make sure you use a min-height:100vh to do this.

  Replace your DIV with main to ensure you are using a landmark and maybe replace the <p class="intro"> with a heading tag. Try using a <h1> as its the most important part.

  Otherwise, good job!

  Marked as helpful

  0

  This comment has received 1 replyShow
• 

  Laynoks• 10

  @Laynoks

  Submitted over 1 year ago

  

  qr-code-component

  2

  30

  

  Michael Sutcliffe• 40

  @msutcliffe2303

  Posted over 1 year ago

  Hey, this is great!

  I'd suggest changing the height:100vh to a min-height:100vh instead.

  I would also look at replacing PX values with REM or EM values. Typically EM is for padding, margin, widths and borders. Then REM for font sizes.

  Also replace your <div class="container"> with a <main class="container"> to clear the warning.

  Good work and happy coding :)

  0