Michael Sutcliffe
@msutcliffe2303All comments
- @karayanikburakSubmitted almost 2 years ago@msutcliffe2303Posted almost 2 years ago
Hey, Congratulations on completing the task!
Theres a few things you could change in this, the first would be using flex or grid to center the content for you. Make sure you use a min-height:100vh to do this.
Replace your DIV with main to ensure you are using a landmark and maybe replace the <p class="intro"> with a heading tag. Try using a <h1> as its the most important part.
Otherwise, good job!
Marked as helpful0 - @LaynoksSubmitted almost 2 years ago@msutcliffe2303Posted almost 2 years ago
Hey, this is great!
I'd suggest changing the height:100vh to a min-height:100vh instead.
I would also look at replacing PX values with REM or EM values. Typically EM is for padding, margin, widths and borders. Then REM for font sizes.
Also replace your <div class="container"> with a <main class="container"> to clear the warning.
Good work and happy coding :)
0