Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

qr-code-component

Laynoks 10

@Laynoks

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Abdessamad 210

@styrexx

Posted

Hi, Laynoks! 👋

Congratulations on completing your first Frontend Mentor challenge! 🎉

There are a few changes you can do to make your solution better.

  • Wrap "Improve Your Front-End Skills By Building Projects" with an <h1> instead of <div> element. Each page should have at one <h1>.
  • Fix the issues that have been reported.

I hope you find this useful. Happy coding! 😄

0

@msutcliffe2303

Posted

Hey, this is great!

I'd suggest changing the height:100vh to a min-height:100vh instead.

I would also look at replacing PX values with REM or EM values. Typically EM is for padding, margin, widths and borders. Then REM for font sizes.

Also replace your <div class="container"> with a <main class="container"> to clear the warning.

Good work and happy coding :)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord