Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code Component with HTML and CSS -frontendmentor.io

Burakβ€’ 10

@karayanikburak

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Francisco Carrilloβ€’ 5,540

@frank-itachi

Posted

Hello there πŸ‘‹. You did a good job!

I have some suggestions about your code that might interest you.

HTML πŸ“„:

  • Wrap the page's whole main content in the <main> tag.
  • Make sure that the <img> elements in your HTML code has an alternate (descriptive text) short text. The reason for this is that screen readers can’t translate images into text. So to fix this you can do the following <img src=”…” alt=”short text” >

CSS 🎨:

  • You can use grid or flexbox to center the content no matter the viewport size. Since I use grid to achieve such purpose, you can do the following:
body {
	min-height: 100vh;
        display: grid;
	align-items: center;
	justify-content: center;
}

As I said, you can use flexbox to center the content and it will work as well.

body {
	min-height: 100vh;
        display: flex;
	align-items: center;
	justify-content: center;
}

I hope you find it useful! πŸ˜„ Above all, the solution you submitted is great!

Happy <coding /> 😎!

Marked as helpful

0

Burakβ€’ 10

@karayanikburak

Posted

@frank-itachi thanks for feedback. Are there any courses or sth you can recommend to me?

0
Francisco Carrilloβ€’ 5,540

@frank-itachi

Posted

@karayanikburak

Check out the Kevin Powell YouTube channel. It'll help you a lot...

0

@msutcliffe2303

Posted

Hey, Congratulations on completing the task!

Theres a few things you could change in this, the first would be using flex or grid to center the content for you. Make sure you use a min-height:100vh to do this.

Replace your DIV with main to ensure you are using a landmark and maybe replace the <p class="intro"> with a heading tag. Try using a <h1> as its the most important part.

Otherwise, good job!

Marked as helpful

0

Burakβ€’ 10

@karayanikburak

Posted

@msutcliffe2303 thank youu

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord