I have used sass/scss, I want feedback on my styling which I adopted to solve this challenge. Any feedback would be really appreciated.
Ali Mousavi Nizhad
@mnizhadali-afgAll comments
- @iprinceroyySubmitted over 2 years ago
- @jeeberharter1Submitted over 2 years ago
Any feedback would be greatly appreciated :)
- @Lomsk1Submitted over 2 years ago
if u have some notice, please tell me
- @MubeenAhmadShaikhSubmitted over 2 years ago
Hello all,
So I tried with starting the sunnyside challenge on frontendmentor. This is my first solution submission I would really appreciate the feedbacks from community.
Thanks, Mubeen
- @estivenson94Submitted over 2 years ago
I noticed that there are some errors and also a repeated .svg id improving little by little.
- @AnaesthCodeSubmitted over 2 years ago
Im open and very grateful of anyone that takes their time to give me feedback to improve.
- @karimsehSubmitted over 2 years ago
Really enjoyed this one! feel free to give a feedback, Thank you.
- @fraserwatSubmitted over 2 years ago
Tried out a new methodology for this, CUBE CSS (there's a good walkthrough of the rationale and a sample web page here). Really really liked this, it's quite utility focused but you don't end up with having to remember 1,000 utilities and make your HTML look incomprehensible like you do with Tailwind (but maybe I'm just using Tailwind wrong!). I feel like my CSS is less repetitive and I feel like I wrote less of it than usual (although that might be due to the relative lack of complexity in the project, and would be difficult to measure given the amt of auto generated classes in the config).
Still going to take a bit of getting used to but I think I'm going to bring this more into my CSS more generally (it works really nicely with SASS).
Towards the end I think I got a bit hacky and there's probably a better way I could have done the layout for Desktop than making the hero image and the stats list
position: absolute
... Any ideas here?@mnizhadali-afgPosted over 2 years agoHey mate, Nice job and keep it up.
Tip: Always remember to use the generic elements inside the Semantic elements. The HTML Semantics are always for wrapping the HTML elements and giving meaning to them.
Good luck :)
Marked as helpful0 - @heba-ibrahemSubmitted almost 3 years ago
- @callsevenSubmitted almost 3 years ago@mnizhadali-afgPosted almost 3 years ago
I think the link for the code is wrong!
Marked as helpful0 - @anoshaahmedSubmitted almost 3 years ago
Would appreciate any advice on where and how to get better. Thank you x
@mnizhadali-afgPosted almost 3 years ago@anoshaahmed - Brilliant Anosha Jan! I have issues with the challenge (Profile Card), can you help with that, please?
1 - @anoshaahmedSubmitted almost 3 years ago
I used desktop-first approach for this, and now I know for sure that mobile-first approach is best.
Please let me know what I can do to improve.
@mnizhadali-afgPosted almost 3 years ago@anoshaahmed your works are awesome and great. I admire it ;)
Marked as helpful1