Skip to content
OverviewSolutions
8
Comments
5

Daniela Darnea

@mdanieladlaSpain180 points

Frontend developer looking for her first career opportunity.

Latest solutions

View more solutions

Latest comments

  • Daniela Darnea•180
    @mdanieladlaPosted about 3 years ago

    Hi! Good job :)

    If I were you I would not mix two languages in the code, i mean, you have almost every class in english <header class="header"> , <div class="header_content">... and then you have some classes in spanish <p class="header_subtitulo">, <h1 class="header_titulo">... and also i wouldn't use uppercase for the beggining of some words like <div class="content_card Supervisor"> because that can confuse you, I think is better to avoid confusion to use all the words in the code in 1 language and also use only lowercase or uppercase, but not both :) (obviuosly the comments you can put them in the same language or in 2,3... like you wish).

    Also semantically instead of using so many divs, is better to use sections and divide the code in sections, for example, instead of having <div class="main_content">, is better to have <section class="main_content">, so then you don't have like 10000 divs :)

    Cheers.

    Marked as helpful
    0
  • Daniela Darnea•180
    @mdanieladlaPosted over 3 years ago

    Good job!! I think (if I remember correctly) that when the user clicks the white button of EXPLORE on the main page, that has to take the user to the destinations page. Cheers :)

    0
  • Daniela Darnea•180
    @mdanieladlaPosted over 3 years ago

    Grid is difficult, but once you understand it, it magically becomes so easy. Here you have 2 resources that have helped me :)

    https://grid.malven.co/ https://cssgridgarden.com/

    0
  • Daniela Darnea•180
    @mdanieladlaPosted over 3 years ago

    Hi! Great job :) If I where you I would have put the click event on the arrow because it is more intuitive for users (in my opinion). Cheers :)

    Marked as helpful
    1
  • Daniela Darnea•180
    @mdanieladlaPosted over 3 years ago

    Good job!! I think (if I remember correctly) that when the user clicks the white button of EXPLORE on the main page, that has to take the user to the destination page. And also if I were you I would fix the HTML issues :)

    Marked as helpful
    1