I'd like receive feedback
Daniela Darnea
@mdanieladlaAll comments
- @apuntesnavarreteSubmitted over 2 years ago@mdanieladlaPosted over 2 years ago
Hi! Good job :)
If I were you I would not mix two languages in the code, i mean, you have almost every class in english <header class="header"> , <div class="header_content">... and then you have some classes in spanish <p class="header_subtitulo">, <h1 class="header_titulo">... and also i wouldn't use uppercase for the beggining of some words like <div class="content_card Supervisor"> because that can confuse you, I think is better to avoid confusion to use all the words in the code in 1 language and also use only lowercase or uppercase, but not both :) (obviuosly the comments you can put them in the same language or in 2,3... like you wish).
Also semantically instead of using so many divs, is better to use sections and divide the code in sections, for example, instead of having <div class="main_content">, is better to have <section class="main_content">, so then you don't have like 10000 divs :)
Cheers.
Marked as helpful0 - @orkhaiSubmitted almost 3 years ago
As always any feedback on my code would be highly appreciated.
@mdanieladlaPosted almost 3 years agoGood job!! I think (if I remember correctly) that when the user clicks the white button of EXPLORE on the main page, that has to take the user to the destinations page. Cheers :)
0 - @xvferdySubmitted almost 3 years ago
Have to submit it first so I can see other people solution 😭
The App is not finished but later I will continue it again... Anyway, is there any site or resource to practice
grid
⁉️ cuz this things is really hard for me.@mdanieladlaPosted almost 3 years agoGrid is difficult, but once you understand it, it magically becomes so easy. Here you have 2 resources that have helped me :)
https://grid.malven.co/ https://cssgridgarden.com/
0 - @Taro2211Submitted almost 3 years ago
Hello everyone, this was quite a fun challenge. I have learnt a lot along the way, but I think there are still a lot of things I need to improve. So, how do you think of my solution? Any comment or tip would be a great help. Thank you in advance.
@mdanieladlaPosted almost 3 years agoHi! Great job :) If I where you I would have put the click event on the arrow because it is more intuitive for users (in my opinion). Cheers :)
Marked as helpful1 - @DiegoSt23Submitted almost 3 years ago
Hello, this is my first project here. Any feedback is always welcome.
@mdanieladlaPosted almost 3 years agoGood job!! I think (if I remember correctly) that when the user clicks the white button of EXPLORE on the main page, that has to take the user to the destination page. And also if I were you I would fix the HTML issues :)
Marked as helpful1