Skip to content
OverviewSolutions
9
Comments
7
Marcelina
@marce7ina

All comments

  • TheWizCoder•120
    @TheWizCoderSubmitted 9 months ago
    What are you most proud of, and what would you do differently next time?

    the most thing that pleased me about this challenge was learning to use grid system

    What challenges did you encounter, and how did you overcome them?

    learning the basics of the grid system was my biggest challenge and took me a lot of time to learn it

    What specific areas of your project would you like help with?

    i wonder if i can add more improvements to the code to make the site look more presentable

    testimonials grid section main

    1
    Marcelina•140
    @marce7inaPosted 9 months ago

    You need to learn how to make the website responsive. Flexbox doesnt work everytime. Give quotation to the first card, use background-image then no-repeat. Try to use more semantic html like article, main, aside etc. instead of div. If you want check my solution its not the best code but maybe it will help.

    0
  • P
    Tuna Erten•430
    @tunaertenSubmitted 9 months ago
    What are you most proud of, and what would you do differently next time?

    I recently learned about the max and min width properties and used them for the first time in this project. I had used clamp in my previous project as well. It's enjoyable to learn and apply new techniques

    What challenges did you encounter, and how did you overcome them?

    I became more familiar with CSS Flexbox. I used pseudo-elements and also utilized the max and min width properties. It was good practice

    What specific areas of your project would you like help with?

    I created the cards using flexbox. When I start to shrink the page, the left and right cards start to shrink, but the sizes of the middle cards do not change. Despite trying many things, I couldn't find a solution to this. I would really appreciate any help

    four-card

    1
    Marcelina•140
    @marce7inaPosted 9 months ago

    You should change the css of "team builder" and "karma" container. It's not responsive because of fixed width. While shirnking card__left and right (almost before changing media to mobile query) computer icon is too close to the text for instance you can try to fix it with margin. I think that rest of code is good i didnt noticed any problems and ofc you made a really good job. Keep going 😄

    Marked as helpful
    0
  • Marcelina•140
    @marce7inaPosted 9 months ago

    Your code is readable, i dont see any bugs in html but something gone wrong with your css. Media queries, doesnt look too good. Text overlaps or is too close to each other when screen has width of 660px (example). I think that changing text settings, line-height, font-size, etc. for mobile devices would be a good solution.

    0
  • P
    Mohd Sadaf•1,050
    @MsadafKSubmitted 9 months ago
    What are you most proud of, and what would you do differently next time?

    the first and foremost i am proud on myself for completing this project. and next time i ll more take care of html semantics and how to document your code more nicely.

    What challenges did you encounter, and how did you overcome them?

    challenges i faced in this project was not so big and hard but they are just little things here n there in css side like making margin between tag bullet point and its content. etc

    What specific areas of your project would you like help with?

    i would like to get help in the responsive part because i did this after a little long time and i am pretty much sure that the responsive part could also be wrote way more better than this.

    Recipe-page responsive design solution

    1
    Marcelina•140
    @marce7inaPosted 9 months ago

    good :)

    1
  • DarkCityTreno•80
    @DarkCityTrenoSubmitted 9 months ago
    What specific areas of your project would you like help with?

    Truly feels like I wrote a lot of unnecessary stuff, most likely made a lot of questionable decisions as well. But this is the best I can do at the moment with my current very limited knowledge.

    Social Links Profile

    2
    Marcelina•140
    @marce7inaPosted 9 months ago

    You should change background-color on a:hover. At your place i would learn how media query works because you didn't use it and website is not responsive for smaller screens.

    Marked as helpful
    1
  • Marcelina•140
    @marce7inaPosted 9 months ago

    everything looks fine :)

    1
  • Marcelina•140
    @marce7inaPosted 9 months ago

    You should use text-align to center your text. To make solution more similar to the design try to change paddings and width of the photo.

    0