@DylandeBruijn
Posted
Hiya @DarkCityTreno,
Great job on another finished project, you are making a lot of progress!
A bit of friendly constructive feedback:
-
Try giving the text in the buttons a darker color on hover, at the moment the text is a bit hard to read.
-
I suggest adding a 'max-width' and 'width: 100%' to your 'main' to make it more responsive. The 'min-width' is not needed in this case.
-
Try giving your elements more descriptive classnames to make it easier for yourself and others to read your code.
-
I recommend not setting a 'height' on your buttons as the text in the button will overflow when it gets larger than the button. A 'min-height' would be better in this case.
-
font-family: inherit;on the buttons is not needed. They inherit thefont-familyfrom thebodydue to cascading. I suggest reading about it here.
I hope you find my feedback helpful and I would appreciate it if you could mark it as helpful if it did!
Happy coding!
Marked as helpful
@DarkCityTreno
Posted
Hey @DylandeBruijn Thanks for another feedback. For some reason buttons didn't inherit fon-family from the body element or at least that's what dev tools in firefox told me, so I kinda "hard coded" it. I'll try to work with your suggestions a bit later today. Very appreciate your feedback, friend!
